-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CountAsLoss + fix CheckStartSolo3v3Arena #19
CountAsLoss + fix CheckStartSolo3v3Arena #19
Conversation
@@ -66,7 +66,6 @@ class Solo3v3BG : public AllBattlegroundScript | |||
uint32 oldTeamRatingHorde; | |||
|
|||
void OnQueueUpdate(BattlegroundQueue* queue, uint32 /*diff*/, BattlegroundTypeId bgTypeId, BattlegroundBracketId bracket_id, uint8 arenaType, bool isRated, uint32 /*arenaRatedTeamId*/) override; | |||
void OnBattlegroundUpdate(Battleground* bg, uint32 /*diff*/) override; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why did you delete this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have the hook OnArenaStart now, so we can use it to call CheckStartSolo3v3.
But we could use OnBGUpdate and check if there's a player that didn't accept the queue and then end the solo earlier, while not in progress, instead of waiting the arena to start
pipeline error
|
It needs azerothcore/azerothcore-wotlk#20039 |
minor issue
|
…er/mod-arena-3v3-solo-queue into fix-CheckStartSolo3v3Arena
My bad, it's fixed now |
this changes need azerothcore/azerothcore-wotlk@f6de601 (merged already)
Changes Proposed:
Issues Addressed:
SOURCE:
Tests Performed:
How to Test the Changes: