Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add command to join solo 3v3 rated #17

Merged
merged 12 commits into from
Sep 13, 2024
Merged

Add command to join solo 3v3 rated #17

merged 12 commits into from
Sep 13, 2024

Conversation

laasker
Copy link
Collaborator

@laasker laasker commented Sep 13, 2024

Changes Proposed:

Issues Addressed:

  • Closes

SOURCE:

Tests Performed:

  • Tested ingame, works good, didn't found any issue

How to Test the Changes:

Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.cpp Outdated Show resolved Hide resolved
Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.cpp Outdated
if (player->InBattleground() || player->InArena() || player->InBattlegroundQueueForBattlegroundQueueType((BattlegroundQueueTypeId)BATTLEGROUND_QUEUE_2v2) ||
player->InBattlegroundQueueForBattlegroundQueueType((BattlegroundQueueTypeId)BATTLEGROUND_QUEUE_3v3) ||
player->InBattlegroundQueueForBattlegroundQueueType((BattlegroundQueueTypeId)BATTLEGROUND_QUEUE_5v5) ||
player->InBattlegroundQueueForBattlegroundQueueType((BattlegroundQueueTypeId)BATTLEGROUND_QUEUE_3v3_SOLO))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ideally we should add the 1v1 too, but maybe under conf

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

true, i forgot about that one

Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.cpp Outdated Show resolved Hide resolved
Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.h Outdated Show resolved Hide resolved
Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.h Outdated Show resolved Hide resolved
Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.h Outdated Show resolved Hide resolved
Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.h Outdated Show resolved Hide resolved
@Helias
Copy link
Member

Helias commented Sep 13, 2024 

/home/runner/work/mod-arena-3v3-solo-queue/mod-arena-3v3-solo-queue/modules/mod-arena-3v3-solo-queue/src/solo3v3_sc.cpp:250:59: fatal error: unused parameter 'creature' [-Wunused-parameter]
  250 | bool NpcSolo3v3::JoinQueueArena(Player* player, Creature* creature, bool isRated)
      |                                                           ^
1 error generated.

https://github.com/azerothcore/mod-arena-3v3-solo-queue/actions/runs/10848687893/job/30106330449?pr=17

Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.cpp Outdated Show resolved Hide resolved
Helias
Helias reviewed Sep 13, 2024
View reviewed changes
src/solo3v3_sc.cpp Outdated Show resolved Hide resolved
@Helias Helias merged commit 07400e1 into azerothcore:master Sep 13, 2024
1 check passed
@laasker laasker deleted the add-command-join-solo branch September 21, 2024 03:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helias Helias Helias approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@laasker @Helias