[suggest] Add command for GM to learn all the available skills at current level

[Bogir]

Changes Proposed:

• learn all the available skills that can be learned throw ClassMaster at current level

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Kitzunu]

Probably better to do after #6109

[FrancescoBorzi]

build fails :(

[Kitzunu]

/home/runner/work/azerothcore-wotlk/azerothcore-wotlk/src/server/scripts/Commands/cs_learn.cpp: In static member function ‘static void learn_commandscript::learn(Player*, std::unordered_map<unsigned int, CreatureTemplate>::const_iterator, CreatureTemplate)’:
/home/runner/work/azerothcore-wotlk/azerothcore-wotlk/src/server/scripts/Commands/cs_learn.cpp:137:81: error: unused parameter ‘itr’ [-Werror=unused-parameter]
  137 |     static void learn(Player* player, CreatureTemplateContainer::const_iterator itr, CreatureTemplate cInfo)
      |                                       ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~
compilation terminated due to -Wfatal-errors.

[Bogir]

ok, rebuilding from every begining .... Let's see..

[Kitzunu]

It wont show on MSVC because it's a forgiving compiler, but you can see the CI's that look for more stuff

[Krejza9]

@Bogir Install Linux and compile it (and Stop using Windows for server apps :-D)

[Bogir]

@Bogir Install Linux and compile it (and Stop using Windows for server apps :-D)

I stopped using *nix in 1992 and I will never come back to it.
If your compiller can't build core - this does not prevent us from working under Win :D
You can fix it to work even on Mars if is it necessary for your system or for your ambitions.
This patch only suggestion and can be not merged, but can be used in private case

[Krejza9]

If you program something for AC , You have to program it so that it can be compiled on Linux, Windows, MacOS.
If you don't care if it doesn't work on other systems.
Then ask someone to fix it, or cancel the PR

[Bogir]

done
Thanks to @Krejza9, @Winfidonarleyan and @FrancescoBorzi for help

[Kitzunu]

alphabetical order

[Yehonal]

Would be better to move the logic of this function in a separate file in order to let people reuse it for other purposes (custom scripts etc).

In this way, modders could create scripts that automatically teach you spells, for instance, when you level up.

[Kitzunu]

I don't agree with handling commands in other files than the designated ones

[Yehonal]

I said "the logic", which means creating a new function elsewhere and using that one in HandleLearnAllMyLvlCommand

that function can be reused then in other scripts/modules/logics

[Kitzunu]

ah, I oversaw that :D