-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Core/Common): delete lib game-interface inherited #5333
feat(Core/Common): delete lib game-interface inherited #5333
Conversation
@azerothcore/testers @Sedatyf can anyone check this please? |
Sorry, I forgot to mention it but I'll test as soon as I get time as it seems it will be a bit long to test |
I'll test this PR today or at least this weekend. Do I have to generate again all maps in order to test it? (mmaps, vmaps, etc.) Or do I just need to pull this PR and do usual steps? |
No need re extract maps |
Hey @Winfidonarleyan, so we tried to clip through wall, we casts fear on each other, and nothing really interesting came up. We tested what you linked on your PR and everything works like a charm. |
Very very good @Sedatyf, thanks for test, i think that's enough. |
merge conflicts |
I have a question. Why delete Blizzard addons? |
Changes Proposed:
game-interface
Issues Addressed:
Tests Performed:
How to Test the Changes:
Target Branch(es):
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.