Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Core/Common): delete lib game-interface inherited #5333

Merged
merged 18 commits into from
May 6, 2021

Conversation

Winfidonarleyan
Copy link
Member

@Winfidonarleyan Winfidonarleyan commented Apr 17, 2021

Changes Proposed:

Issues Addressed:

Tests Performed:

  • In game with 30+ min uptime

How to Test the Changes:

Target Branch(es):

  • Master

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@Winfidonarleyan Winfidonarleyan marked this pull request as ready for review April 18, 2021 21:33
@FrancescoBorzi
Copy link
Contributor

@azerothcore/testers @Sedatyf can anyone check this please?

@Sedatyf
Copy link
Member

Sedatyf commented Apr 27, 2021

@azerothcore/testers @Sedatyf can anyone check this please?

Sorry, I forgot to mention it but I'll test as soon as I get time as it seems it will be a bit long to test

@Sedatyf
Copy link
Member

Sedatyf commented Apr 30, 2021

I'll test this PR today or at least this weekend. Do I have to generate again all maps in order to test it? (mmaps, vmaps, etc.) Or do I just need to pull this PR and do usual steps?

@Winfidonarleyan
Copy link
Member Author

I'll test this PR today or at least this weekend. Do I have to generate again all maps in order to test it? (mmaps, vmaps, etc.) Or do I just need to pull this PR and do usual steps?

No need re extract maps

@Sedatyf
Copy link
Member

Sedatyf commented May 2, 2021

Hey @Winfidonarleyan, so we tried to clip through wall, we casts fear on each other, and nothing really interesting came up. We tested what you linked on your PR and everything works like a charm.
We played like nearly an hour without an issue.
Please tell me if you see some test I could do, otherwise, it seems fine to me

@Winfidonarleyan
Copy link
Member Author

Very very good @Sedatyf, thanks for test, i think that's enough.

@Helias
Copy link
Member

Helias commented May 4, 2021

merge conflicts

@mpfans
Copy link
Contributor

mpfans commented May 5, 2021

I have a question. Why delete Blizzard addons?

@Winfidonarleyan Winfidonarleyan merged commit db7d754 into azerothcore:master May 6, 2021
@Winfidonarleyan Winfidonarleyan deleted the lib-common-inh branch May 6, 2021 19:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants