fix(Scripts/BT) Fix Gurtogg will not use acidic wound in phase 2

[blinkysc]

Changes Proposed:

This PR proposes changes to:

• Core (units, players, creatures, game systems).
• Scripts (bosses, spell scripts, creature scripts).
• Database (SAI, creatures, etc).

Issues Addressed:

• Closes [Black Temple] Boss: Gurtogg Bloodboil shouldn't apply Acidic Wound in Phase 2 #21204

SOURCE:

The changes have been validated through:

• Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
• Sniffs (remember to share them with the open source community!)
• Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
• The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found

Tests Performed:

This PR has been:

• Tested in-game by the author.
• Tested in-game by other community members/someone else other than the author/has been live on production servers.
• This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

• This pull request can be tested by following the reproduction steps provided in the linked issue
• This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

1. Use bots or other players so no reset during bewildering strikes
2. .go c id 22948
3. Wait for fel rage and observe no acid wound
4. After fel rage acid wound should be used again

Known Issues and TODO List:

• [ ]
• [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

[Nyeriah]

Ive explained the issue in detail here: #21208 (comment)

I am not certain how giving him the aura again would be able to address this issue

[blinkysc]

Ive explained the issue in detail here: #21208 (comment)

I am not certain how giving him the aura again would be able to address this issue

Honestly not sure why that's the case as well, I took this from the original script and applied it to when fel rage happens with 28s timer (based on fel rage instead of checking if any player has it). I have tested and works but I'll keep looking for a more appropriately named function

[blinkysc]

So apparently DoCastVictim() works the same here ¯\(ツ)/¯, I changed the old line of code as well. Also tested again

[Nyeriah]

So apparently DoCastVictim() works the same here ¯_(ツ)_/¯, I changed the old line of code as well. Also tested again

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA)
BasePoints = I
Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)

40484 has TARGET_UNIT_CASTER as target so it has only one valid target, himself. So DoCastSelf() is the appropriate choice here

[blinkysc]

So apparently DoCastVictim() works the same here ¯_(ツ)_/¯, I changed the old line of code as well. Also tested again

Effect 0: Id 6 (SPELL_EFFECT_APPLY_AURA) BasePoints = I Targets (1, 0) (TARGET_UNIT_CASTER, NO_TARGET)

40484 has TARGET_UNIT_CASTER as target so it has only one valid target, himself. So DoCastSelf() is the appropriate choice here

DoCastSelf() back

[amed80]

Gurtogg still uses acidic wound in phase 2.

[blinkysc]

Gurtogg still uses acidic wound in phase 2.

Tried another 2 times, but I don't ever see Gurtogg apply acidic wound while fel rage. Do you see the same behavior before or any difference?

[Nyeriah]

Do you have uncommited changes by any chance?

[amed80]

Gurtogg still uses acidic wound in phase 2.

Tried another 2 times, but I don't ever see Gurtogg apply acidic wound while fel rage. Do you see the same behavior before or any difference?

tested again
i see same behavior before and after the PR

AzerothCore rev. a13c2ff+ 2025-01-23 17:30:31 +0000 (master branch) (Win64, RelWithDebInfo, Static)

No modules are enabled

[blinkysc]

Gurtogg still uses acidic wound in phase 2.

Tried another 2 times, but I don't ever see Gurtogg apply acidic wound while fel rage. Do you see the same behavior before or any difference?

tested again i see same behavior before and after the PR

AzerothCore rev. a13c2ff+ 2025-01-23 17:30:31 +0000 (master branch) (Win64, RelWithDebInfo, Static)

No modules are enabled

You'll have to checkout the PR before testing, unless of course you just copy pasta?

https://graphite.dev/guides/git-checkout-pr

[Nyeriah]

Remove the aura at start of p2

[blinkysc]

Remove the aura at start of p2

Acidic Wound shouldn't be removed from players if I'm not mistaken just that new applications should not be applied?
https://www.youtube.com/watch?v=yPaj1Wpd6cE -> around 1:28 you can see player still has debuff with fel rage

[Nyeriah]

yes... I mean.. from the boss..

[amed80]

You'll have to checkout the PR before testing, unless of course you just copy pasta?

https://graphite.dev/guides/git-checkout-pr

usually do it manually but tried again

AzerothCore rev. dffb89b 2025-01-23 20:57:24 -0600 (pr-21253 branch) (Win64, RelWithDebInfo, Static)

Acidic.mp4

[blinkysc]

yes... I mean.. from the boss..

Boss never has the Aura, that was the confusion with DoCastSelf() even though its an offensive ability (from Gurtogg's perspective)

[blinkysc]

You'll have to checkout the PR before testing, unless of course you just copy pasta?
https://graphite.dev/guides/git-checkout-pr

usually do it manually but tried again

AzerothCore rev. dffb89b 2025-01-23 20:57:24 -0600 (pr-21253 branch) (Win64, RelWithDebInfo, Static)
Acidic.mp4

Oh I see, maybe weird timing issue. Maybe what I can do is something like 100-300ms before fel rage he stops acidic wound and maybe 100ms after?

[blinkysc]

Also @amed80 no more is applied after that initial one right? During Fel Rage that is

[amed80]

it keeps applying for the whole phase 2

[blinkysc]

it keeps applying for the whole phase 2

Mind trying again with this commit?

[Nyeriah]

Gurtogg casts the aura (SPELL_ACIDIC_WOUND) on himself on pull, the aura then triggers the application as long as he has the aura.

[blinkysc]

Gurtogg casts the aura (SPELL_ACIDIC_WOUND) on himself on pull, the aura then triggers the application as long as he has the aura.

I see ok let me fix that

[EricksOliveira]

This problem is quite intriguing. I haven't had time to fix my commit, but I believe the best way to fix this problem is to create phases on the boss. I'll be looking into this tomorrow, when I'm less busy at work.

[blinkysc]

I've tried and tried but from what I see acid wound isn't happening to players in Phase 2 with latest commit. The Aura is removed on Gurtogg during Phase 2 and he waits 28s to reapply. What you think @Nyeriah ?

[blinkysc]

@amed80 if you woundn't mind trying again when you have a chance

[amed80]

Yes , tested 3 Fel Rage phases.
He doesn't apply it during p2 and he applies it again after going back to p1.