Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(Core/Misc): Use steady_timer instead of deadline_timer #20940

Merged
merged 3 commits into from
Dec 19, 2024

Conversation

Kitzunu
Copy link
Member

@Kitzunu Kitzunu commented Dec 16, 2024

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).

Swap deadline_timer to steady_timer as it started to deprecate in boost 1.7 and is completely deprecated in 1.78.

This allows AC to run on Boost 1.78, as well as earlier versions.

Tests Performed:

This PR has been:

I have started the worldserver.
No extensive tests have been done

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.

Known Issues and TODO List:

  • [ ]
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@github-actions github-actions bot added CORE Related to the core file-cpp Used to trigger the matrix build labels Dec 16, 2024
@Exitare
Copy link
Member

Exitare commented Dec 17, 2024

@Kitzunu what test(s) need to be done in order to test this change?
Different boost versions?

@Kitzunu
Copy link
Member Author

Kitzunu commented Dec 17, 2024

Nah it works with all boost.
Honestly I would just say, check that everything works as normal and saves correctly.

The timers touch

  • FreezeDetector
  • DB ping
  • Ban Expiry check
  • Metrics
  • Realm
    iirc

@Exitare
Copy link
Member

Exitare commented Dec 18, 2024

I think its working. Compile is fine. Timers in boss fights too. Realm holds up fine too. Metrics look good to me too.

I wanted to check ban expiration by using
.ban character
but i am quite certain that there is an issue with inserting the correct values into the database.
Right now the command will always result in a perm ban because it doesnt translate the ban time correctly to seconds. its always zero, resulting in ban and unbantime being the same. But apparently the core is not cleaning that up either

As far as this PR is concered i tested it and couldnt observe a noticable difference.

@Grimdhex Grimdhex added To Be Merged Tested This PR has been tested and is working. and removed Waiting to be Tested Ready to be Reviewed labels Dec 18, 2024
@Grimdhex
Copy link
Contributor

I will merge it tomorrow. I avoid doing new merge before the CC update.

@sudlud
Copy link
Member

sudlud commented Dec 18, 2024

Please merge master for CI codecheck fix

@Kitzunu
Copy link
Member Author

Kitzunu commented Dec 18, 2024

This will fix mac os ci too

@sudlud sudlud merged commit 0bc7067 into azerothcore:master Dec 19, 2024
13 checks passed
xpdemon pushed a commit to xpdemon/azerothcore-wotlk that referenced this pull request Dec 25, 2024
skelUA added a commit to skelUA/wotlk that referenced this pull request Jan 4, 2025
skelUA added a commit to skelUA/wotlk that referenced this pull request Jan 4, 2025
skelUA added a commit to skelUA/wotlk that referenced this pull request Jan 15, 2025
skelUA added a commit to skelUA/wotlk that referenced this pull request Jan 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core file-cpp Used to trigger the matrix build Tested This PR has been tested and is working. To Be Merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants