Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move Fairbanks gossip to the database #16974

Merged
merged 11 commits into from
Sep 17, 2023

Conversation

fangshun2004
Copy link
Contributor

@fangshun2004 fangshun2004 commented Aug 10, 2023

Move Fairbanks gossip to the database.
The gossip id and option id use the IDs of vmangos and cmaogs
Some emoticons in gossip hold a weapon in your hand when used (when using emoticons on Blizzard servers, you will hold them on your waist and hold them in your hand when the emoji is finished) So I use smatAI to complete the emoticons.

Changes Proposed:

This PR proposes changes to:

  • Core (units, players, creatures, game systems).
  • Scripts (bosses, spell scripts, creature scripts).
  • Database (SAI, creatures, etc).

If your pull request promotes complex changes that require a detailed explanation, please describe them in detail specifying what your solution is and what is it meant to address.

Issues Addressed:

  • Closes

SOURCE:

The changes have been validated through:

  • Live research (checked on live servers, e.g Classic WotLK, Retail, etc.)
  • Sniffs (remember to share them with the open source community!)
  • Video evidence, knowledge databases or other public sources (e.g forums, Wowhead, etc.)
    Video source https://www.bilibili.com/video/BV1yA411Q7XC/?t=7.4
  • The changes promoted by this pull request come partially or entirely from another project (cherry-pick). Cherry-picks must be committed using the proper --author tag in order to be accepted, thus crediting the original authors, unless otherwise unable to be found
    The source of the ID of the gossip in cmangos I don't know which author is

Tests Performed:

This PR has been:

  • Tested in-game by the author.
  • Tested in-game by other community members/someone else other than the author/has been live on production servers.
  • This pull request requires further testing and may have edge cases to be tested.

How to Test the Changes:

  • This pull request can be tested by following the reproduction steps provided in the linked issue
  • [] This pull request requires further testing. Provide steps to test your changes. If it requires any specific setup e.g multiple players please specify it as well.
  1. .additem 22691
  2. .instance unbind all
  3. Equip Ashbringer and talk to NPCs
  4. .go xyz 1165.900 1352.739 31.549 189
  5. Most of the gossip content has 3 emoticons, and every time you do an emoji, you put your weapon on your waist and hold it in your hand when you're done
    6.Destroy the Ashbringer The gossip option for NPCs should disappear

Known Issues and TODO List:

  • Some expressions in the first conversation, still holding a weapon in your hand, and normal when you talk again
  • [ ]

How to Test AzerothCore PRs

When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].

You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:

http://www.azerothcore.org/wiki/How-to-test-a-PR

REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).

For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.

@yehonal-bot yehonal-bot added CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Script labels Aug 10, 2023
@@ -0,0 +1,183 @@
#######################creature_template ###################
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use -- as comments in SQL files.

(7283, 0, 0, 'Curse? What\'s going ON here, Fairbanks?', 12481, 1, 1, 7282, 0, 0, 0, '', 0, 0);

###########npc_text###########
##cmangos npc_text_broadcast_text
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove broadcast_text, CI doesn't like it =)

Comment on lines 715 to 716
//Gossip in Blizzard servers with a weapon in his hand when he gossips
//me->SetSheath(SHEATH_STATE_UNARMED);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if not used, delete it

}

struct npc_fairbanksAI : public SmartAI
struct npc_fairbanksAI : public SmartAI
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
struct npc_fairbanksAI : public SmartAI
struct npc_fairbanksAI : public SmartAI

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix the spacing

@Kitzunu Kitzunu merged commit 533b364 into azerothcore:master Sep 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CORE Related to the core DB related to the SQL database file-cpp Used to trigger the matrix build Script Waiting to be Tested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants