-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move Fairbanks gossip to the database #16974
Conversation
…_menu_option be displayed
…wotlk into fairbanks_gossip
@@ -0,0 +1,183 @@ | |||
#######################creature_template ################### |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use --
as comments in SQL files.
(7283, 0, 0, 'Curse? What\'s going ON here, Fairbanks?', 12481, 1, 1, 7282, 0, 0, 0, '', 0, 0); | ||
|
||
###########npc_text########### | ||
##cmangos npc_text_broadcast_text |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove broadcast_text
, CI doesn't like it =)
//Gossip in Blizzard servers with a weapon in his hand when he gossips | ||
//me->SetSheath(SHEATH_STATE_UNARMED); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
if not used, delete it
} | ||
|
||
struct npc_fairbanksAI : public SmartAI | ||
struct npc_fairbanksAI : public SmartAI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
struct npc_fairbanksAI : public SmartAI | |
struct npc_fairbanksAI : public SmartAI |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fix the spacing
Replace npc_text_broadcast_text with npc_text_broa*dcast_text
Move Fairbanks gossip to the database.
The gossip id and option id use the IDs of vmangos and cmaogs
Some emoticons in gossip hold a weapon in your hand when used (when using emoticons on Blizzard servers, you will hold them on your waist and hold them in your hand when the emoji is finished) So I use smatAI to complete the emoticons.
Changes Proposed:
This PR proposes changes to:
If your pull request promotes complex changes that require a detailed explanation, please describe them in detail specifying what your solution is and what is it meant to address.
Issues Addressed:
SOURCE:
The changes have been validated through:
Video source https://www.bilibili.com/video/BV1yA411Q7XC/?t=7.4
The source of the ID of the gossip in cmangos I don't know which author is
Tests Performed:
This PR has been:
How to Test the Changes:
6.Destroy the Ashbringer The gossip option for NPCs should disappear
Known Issues and TODO List:
How to Test AzerothCore PRs
When a PR is ready to be tested, it will be marked as [WAITING TO BE TESTED].
You can help by testing PRs and writing your feedback here on the PR's page on GitHub. Follow the instructions here:
http://www.azerothcore.org/wiki/How-to-test-a-PR
REMEMBER: when testing a PR that changes something generic (i.e. a part of code that handles more than one specific thing), the tester should not only check that the PR does its job (e.g. fixing spell XXX) but especially check that the PR does not cause any regression (i.e. introducing new bugs).
For example: if a PR fixes spell X by changing a part of code that handles spells X, Y, and Z, we should not only test X, but we should test Y and Z as well.