mv try catch out of main function #3
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good. |
|
Done. |
| var json; | ||
|
|
||
| if (!error) | ||
| error = tryit(function() { |
There was a problem hiding this comment.
error = is not needed since tryit doesn't return any values.
https://github.com/HenrikJoreteg/tryit/blob/master/tryit.js
|
Done. |
|
Hi all, sorry for late reply. I saw this PR before but didn't know how to respond as it's doing multiple things in one PR and I'm not sure what you mean by; Does it have a bug that I'm not realizing ? Or are you just moving try-catch for optimization ? |
|
It's done with try-call module now; https://github.com/azer/read-json/blob/master/index.js#L14 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moved
try-catchto another function to improve speed.Callback called twice when error occur:
errorundefinedOptimization killers