Upgrade codelyzer to fix lint bug not detecting inheritance in templates

See: mgechev/codelyzer#191
azavea · Jan 5, 2018 · dea9c39 · dea9c39
1 parent 0706717
commit dea9c39
Show file tree

Hide file tree

Showing 7 changed files with 4 additions and 14 deletions.
diff --git a/src/angular/planit/package.json b/src/angular/planit/package.json
@@ -43,7 +43,7 @@
     "@types/jasmine": "~2.5.53",
     "@types/jasminewd2": "~2.0.2",
     "@types/node": "~6.0.60",
-    "codelyzer": "~3.2.0",
+    "codelyzer": "~4.0.2",
     "jasmine-core": "~2.6.2",
     "jasmine-spec-reporter": "~4.1.0",
     "karma": "~1.7.0",

diff --git a/src/angular/planit/src/app/risk-wizard/steps/capacity-step/capacity-step.component.ts b/src/angular/planit/src/app/risk-wizard/steps/capacity-step/capacity-step.component.ts
@@ -54,8 +54,6 @@ export class CapacityStepComponent extends WizardStepComponent<Risk, CapacitySte
     };
   }
 
-  save() {}
-
   getFormModel(): CapacityStepFormModel {
     const data: CapacityStepFormModel = {
       adaptiveCapacity: this.form.controls.adaptiveCapacity.value,

diff --git a/src/angular/planit/src/app/risk-wizard/steps/hazard-step/hazard-step.component.ts b/src/angular/planit/src/app/risk-wizard/steps/hazard-step/hazard-step.component.ts
@@ -53,8 +53,6 @@ export class HazardStepComponent extends WizardStepComponent<Risk, HazardStepFor
     this.form.get('intensity').valueChanges.subscribe(v => console.log('intensity: ', v));
   }
 
-  save() {}
-
   getFormModel(): HazardStepFormModel {
     const data: HazardStepFormModel = {
       frequency: this.form.controls.frequency.value,

diff --git a/src/angular/planit/src/app/risk-wizard/steps/identify-step/identify-step.component.ts b/src/angular/planit/src/app/risk-wizard/steps/identify-step/identify-step.component.ts
@@ -66,8 +66,6 @@ export class IdentifyStepComponent extends WizardStepComponent<Risk, IdentifySte
     this.router.navigate(['assessment']);
   }
 
-  save() {}
-
   fromModel(risk: Risk): IdentifyStepFormModel {
     return {
       weatherEvent: risk.weatherEvent,

diff --git a/src/angular/planit/src/app/risk-wizard/steps/impact-step/impact-step.component.ts b/src/angular/planit/src/app/risk-wizard/steps/impact-step/impact-step.component.ts
@@ -44,8 +44,6 @@ export class ImpactStepComponent extends WizardStepComponent<Risk, ImpactStepFor
     this.setupForm(this.fromModel(this.risk));
   }
 
-  save() {}
-
   getFormModel(): ImpactStepFormModel {
     const data: ImpactStepFormModel = {
       impactMagnitude: this.form.controls.impactMagnitude.value,

diff --git a/src/angular/planit/src/app/shared/chart/chart.component.ts b/src/angular/planit/src/app/shared/chart/chart.component.ts
@@ -31,7 +31,7 @@ import * as cloneDeep from 'lodash.clonedeep';
 })
 export class ChartComponent implements OnChanges, OnDestroy, OnInit {
 
-  @Output() onExtraParamsChanged = new EventEmitter<IndicatorQueryParams>();
+  @Output() extraParamsChanged = new EventEmitter<IndicatorQueryParams>();
 
   @Input() indicator: Indicator;
   @Input() dataset: Dataset;
@@ -158,7 +158,7 @@ export class ChartComponent implements OnChanges, OnDestroy, OnInit {
 
   public onExtraParamsSelected(params: IndicatorQueryParams) {
     this.extraParams = params;
-    this.onExtraParamsChanged.emit(this.extraParams);
+    this.extraParamsChanged.emit(this.extraParams);
     this.updateChart(this.extraParams);
   }
 

diff --git a/src/angular/planit/tslint.json b/src/angular/planit/tslint.json
@@ -135,8 +135,6 @@
     "use-pipe-transform-interface": true,
     "component-class-suffix": true,
     "directive-class-suffix": true,
-    "no-access-missing-member": true,
-    "templates-use-public": true,
-    "invoke-injectable": true
+    "no-output-on-prefix": true
   }
 }