Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document macOS setup instructions #499

Merged
merged 1 commit into from
Oct 16, 2018
Merged

Document macOS setup instructions #499

merged 1 commit into from
Oct 16, 2018

Conversation

kellyi
Copy link

@kellyi kellyi commented Oct 15, 2018

Overview

This PR updates the Raster Vision docs to include macOS specific setup instructions which I used to circumvent the problems I encountered in #487.

The minimal set of manual installation requirements seems to be:

pip install cython
pip install git+https://github.com/jswhit/pyproj.git

...before pip install rastervision. The git+https install for pyproj seems to be required on macOS, according to pyproj4/pyproj#138 and pyproj4/pyproj#136

Testing Instructions

From a clean install on macOS High Sierra, follow the the new macOS specific setup instructions and verify that they work.

After installation, you should be able to run

$ python3
>>> import rastervision

...without error.

Closes #487

docs/setup.rst Outdated
@@ -16,6 +16,20 @@ You can get the library directly from PyPI:

.. note:: Raster Vision requires Python 3 or later.

macOS Installation
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did not have to do this for my MacOS installation, for whatever reason - it could be because the necessary libraries were installed with other dependencies previously. Considering that, should we frame this more as a "if you have the following issues, you might need to do this" rather than as the definitive Mac install instructions? That way we don't encourage folk to install an unreleased version of pyproj if they don't have to.

I think another thing besides Mac that's worth maybe mentioning is that it's a python 3.7 issue (which was mentioned in the pyproj issues you linked to in #487)

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, okay -- that makes sense. If we're okay keeping the header, I can change it to something like...

Troubleshooting macOS Installation

If you encounter problems running pip install rastervision on macOS, you may have to manually install Cython and pyproj. To circumvent an issue installing pyproj with Python 3.7, you may also have to install it using git+https:

... instructions

Tensorflow header

....

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that makes sense. Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cool. Updated and squashed!

Getting `pip install rastervision` to work on macOS may require
installing some dependencies manually. This change updates the
documentation to add guidance for installing Cython as a pre-req as well
as guidance for installing pyproj with git+https when using Python 3.7.

The change also places a subheading before the AWS/Tensorflow/Keras installation
instructions to distinguish them from the macOS troubleshooting
instructions.
@lossyrob
Copy link
Contributor

Great, thank you. I'll merge once Travis goes green.

@lewfish lewfish merged commit 361b878 into azavea:develop Oct 16, 2018
@lewfish lewfish removed the review label Oct 16, 2018
@lewfish
Copy link
Contributor

lewfish commented Oct 16, 2018

I cherry picked the commit to the 0.8 branch so it should be on the docs site soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants