Compute RasterStats
from transformed RasterSource
#2211
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR makes
RasterStats
useRasterSource.get_chip()
instead ofRasterSource.get_raw_chip()
when computing stats (#2177). This requires 2 further downstream changes:RasterSource.channel_order
which makes thechannel_order
argument toStatsTransformer
unnecessary. SinceStatsTransformer
was the onlyRasterTransformer
using this argument, this meant that the argument could now safely be removed from allRasterTransformer
s--and it was.RasterSource.get_raw_chip()
, they still requirechannel_order
to be applied before they can be used by theStatsTransformer
. Therefore, to maintain backward compatibility with older model-bundles, a new booleanneeds_channel_order
field has been added toStatsTransformerConfig
, which, ifTrue
, causeschannel_order
to be applied when initializing theStatsTransformer
inStatsTransformerConfig.build()
. This field is set automatically by the config upgrader.Checklist
needs-backport
label if the change should be back-ported to the previous releaseNotes
N/A
Testing Instructions
See new/updated unit tests.
Closes #2177