Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: ensure SS datasets always return label array with correct dtype #1954

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

AdeelH
Copy link
Collaborator

@AdeelH AdeelH commented Oct 5, 2023

Overview

This PR fixes a bug, reported in #1950, where SS datasets would return y without converting it to the right integer dtype first.

Checklist

  • Added needs-backport label if PR is bug fix that applies to previous minor release
  • Ran scripts/format_code and committed any changes
  • Documentation updated if needed
  • PR has a name that won't get you publicly shamed for vagueness

Notes

N/A

Testing Instructions

  • See new unit tests.

@AdeelH AdeelH added the needs-backport This PR needs to be backported to release branches label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #1954 (4adf90e) into master (89e8ce7) will increase coverage by 0.02%.
Report is 1 commits behind head on master.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #1954      +/-   ##
==========================================
+ Coverage   82.46%   82.48%   +0.02%     
==========================================
  Files         190      190              
  Lines        9336     9337       +1     
==========================================
+ Hits         7699     7702       +3     
+ Misses       1637     1635       -2     
Files Coverage Δ
.../rastervision/pytorch_learner/dataset/transform.py 95.96% <100.00%> (+0.84%) ⬆️

... and 1 file with indirect coverage changes

@AdeelH AdeelH marked this pull request as ready for review October 5, 2023 14:47
@AdeelH AdeelH merged commit e4e10ad into azavea:master Oct 5, 2023
1 check passed
@AdeelH AdeelH deleted the ss-y-long branch October 5, 2023 19:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-backport This PR needs to be backported to release branches
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant