This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Feature/kak/update dependencies#187 #228
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Using `ncu -a`. Closes azavea#187.
Fix error on npm serve: `Cannot find module webpack/lib/node/NodeTemplatePlugin`.
For updated npm packages and added webpack.
Fixes error after package upgrade: `Cannot import type declaration files. Consider importing geojson instead of @types/geojson.`.
After package upgrade, errors on `ThresholdIndicatorQueryOpts` type extension. Sub-object no longer inherits properties and must now explicitly list them.
CloudNiner
approved these changes
Aug 31, 2017
| import { IndicatorQueryOpts } from './indicator-query-opts.model'; | ||
|
|
||
| export interface ThresholdIndicatorQueryOpts extends IndicatorQueryOpts { | ||
| params: { | ||
| threshold: Number; | ||
| threshold_units: string; | ||
| threshold_comparator: string; | ||
|
|
||
| // from base |
There was a problem hiding this comment.
I originally did this as well after the TS2.4 upgrade, but then went further down the rabbit hole and refactored IndicatorQueryOpts such that IndicatorQueryOpts.params is now interface IndicatorParams instead of any, and can be extended by ThresholdIndicatorParams. ThresholdIndicatorQueryOpts disappears.
No action necessary here, just more of a heads up that a larger change related to this is coming in the PR for #212. It enforces type checking far better in a few places, and avoids the awkwardness of having to redefine parameters as is done here.
4 tasks
Linter now warns of shadowed variables.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Update npm dependencies, using
ncu -a. Fixes some resulting server errors.Notes
Doing this task now in case the updates to the karma Chrome launcher might help in addressing some of the spurious Jenkins test run failures. If not, will try the
--no-sandboxflag workaround described here.Testing Instructions
Closes #187.