Feature/kak/update packages#994

[flibbertigibbet]

Overview

Update dependencies.

Testing Instructions

• vagrant destroy app
• Delete contents of src/node_modules and src/bower_components
• vagrant up
• User-facing and admin sites should continue to work as expected

Closes #994

[KlaasH]

I'm getting warnings like this:

- azavea.opentripplanner (1.0.8) was installed successfully
 [WARNING]: - dependency azavea.git from role azavea.opentripplanner differs from already installed version
(0.1.0), skipping

 [WARNING]: - dependency azavea.java from role azavea.opentripplanner differs from already installed version
(0.6.1), skipping

Maybe that's not new--I didn't check what it was doing before. It seems to be a case of the opentripplanner role having a unrestricted dependencies (https://github.com/azavea/ansible-opentripplanner/blob/develop/meta/main.yml#L17-L18) that presumably resolve to newer versions.

[flibbertigibbet]

If these also come from another role, maybe they can be left out of this file altogether. I'll see what that does.

[flibbertigibbet]

Can simply omit them here, so will do that. Looks like ansible role versioning support is limited: ansible/proposals#23

[KlaasH]

Another in the category of "I haven't actually tried it in a while so I don't know if this works in develop":
When I run npm run gulp-test-dev, I get

vagrant@app:/opt/app/src$ npm run gulp-test-dev

> @ gulp-test-dev /opt/app/src
> gulp test:development

[19:19:13] Using gulpfile /opt/app/src/gulpfile.js
[19:19:13] Starting 'copy:vendor-scripts'...
[19:19:13] Starting 'copy:scripts'...
[19:19:14] Finished 'copy:vendor-scripts' after 688 ms
[19:19:14] Finished 'copy:scripts' after 536 ms
[19:19:14] Starting 'test:development'...
12 03 2018 19:19:14.956:ERROR [plugin]: Error during loading "/opt/app/src/node_modules/karma-phantomjs-launc$
er" plugin:
  Path must be a string. Received null
12 03 2018 19:19:15.445:INFO [karma]: Karma v2.0.0 server started at http://0.0.0.0:9876/
12 03 2018 19:19:15.445:INFO [launcher]: Launching browser PhantomJS with unlimited concurrency
12 03 2018 19:19:15.446:ERROR [karma]: Found 1 load error
[19:19:15] 'test:development' errored after 1.16 s
[19:19:15] Error: 1
    at formatError (/opt/app/src/node_modules/gulp/bin/gulp.js:169:10)
    at Gulp.<anonymous> (/opt/app/src/node_modules/gulp/bin/gulp.js:195:15)
    at emitOne (events.js:116:13)
    at Gulp.emit (events.js:211:7)
    at Gulp.Orchestrator._emitTaskDone (/opt/app/src/node_modules/orchestrator/index.js:264:8)
    at /opt/app/src/node_modules/orchestrator/index.js:275:23
    at finish (/opt/app/src/node_modules/orchestrator/lib/runTask.js:21:8)
    at cb (/opt/app/src/node_modules/orchestrator/lib/runTask.js:29:3)
    at removeAllListeners (/opt/app/src/node_modules/karma/lib/server.js:421:7)
    at Server.<anonymous> (/opt/app/src/node_modules/karma/lib/server.js:432:9)
    at Object.onceWrapper (events.js:313:30)
    at emitNone (events.js:111:20)
    at Server.emit (events.js:208:7)
    at emitCloseNT (net.js:1671:8)
    at _combinedTickCallback (internal/process/next_tick.js:135:11)
    at process._tickCallback (internal/process/next_tick.js:180:9)

[flibbertigibbet]

The gulp-test-dev task has not been in use for some time; gulp-test is the meta-task this project uses for tests. It runs tests for production and builds both production and development, but does not run tests also on development; that was due to timing conflicts with async tasks, as I recall.

In any case, tests in general (gulp-test) were broken by this, so reverted the npm package changes.

[flibbertigibbet]

build again

[flibbertigibbet]

build again

[KlaasH]

Looks good 👍