-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
…2725) ### Issue # (if applicable) No ### Reason for this change Generating the metafile in a Windows environment can fail when the path are not enclosed with quotes. ### Description of changes #### What code changes did you make? Enclosed paths the bundling arguments `--metafile` and `--tsconfig` #### Have you made any important design decisions? No #### What AWS use cases does this change enable? To enable the use cases, which AWS service features are utilized? Allows safe usage of `metafile` and `tsconfig` bundling options ### Describe any new or updated permissions being added <!— What new or updated IAM permissions are needed to support the changes being introduced ? --> ### Description of how you validated changes #### Have you added any unit tests and/or integration tests? No, but when you have a project path with a whitespace, and use the `metafile` bundling argument, the metafile path should be passed correctly within quotes to esbuild. I updated the existing tests. ### Checklist - [x] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md) ---- *By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
- Loading branch information
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
import { mult } from '../util'; | ||
|
||
export async function handler(): Promise<void> { | ||
console.log(mult(3, 4)); // eslint-disable-line no-console | ||
} |
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.