Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add turbo speed hotkey #605

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

OpenSauce04
Copy link
Member

Rebased from #455 by @kleidis

Closes #414

Adds a new turbo speed slider to the general tab along with a new hotkey which once pressed, toggles the frame_limit setting % to match the `turbo speed slider value. Once the hotkey the hotkey pressed again, it returns to the global frame_limit value the user originally had

A few changes were made to the original behavior as well (on QT)

  • The frame_limit slider is licked at runtime
    • Due to the way the slider originally worked, leaving this changeable at runtime would cause issues with the hew hotkey also changing the frame limit setting key, meaning toggling to turbo mode also changed the global frame_limit value. So the most straightforward way I thought of fixing this was to just lock the slider at runtime and return the original non-turbo value once the game is closed
  • Increase/ Decrease Hotkey also got changed to modify the new turbo speed key instead of the original frame_limit key directly like it was before
    • This makes it easier to restore the original frameskip value after the end of a gaming session

@OpenSauce04 OpenSauce04 added the enhancement New feature or request label Mar 1, 2025
@OpenSauce04 OpenSauce04 added the squash This pull request should be squashed if approved label Mar 1, 2025
@OpenSauce04 OpenSauce04 added this to the 2121 milestone Mar 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/L squash This pull request should be squashed if approved
Projects
None yet
2 participants