Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

android: Implement quick configure for external controllers #599

Draft
wants to merge 6 commits into
base: master
Choose a base branch
from

Conversation

OpenSauce04
Copy link
Member

@OpenSauce04 OpenSauce04 commented Mar 1, 2025

Rebased from #283 by @newhinton

This PR implements a fast-button-mapper.

The user can now click the Auto Configuration setting in the gamepad-section, which will open a new dialog.
This dialog will then iterate over the available buttons, where the user can quickly press a button on the gamepad without having to pre-select which button this press should be assigned to.
image

This PR is currently a work in progress.

Todo's:

  • Fix Analog Axis assignment
  • Change strings to a consistent namingscheme, also figure out how this should be called
  • Evaluate MotionBottomSheetDialogFragment so that we don't have code duplication like now
  • Clicking the Next button seems to not actually skip to the next button the first time you press it, instead duplicating the button into both the current and previous button slots. It must be pressed a second time to actually progress to the next button
  • Closing the prompt before reaching the end still applies all previously selected binds. The binds should only be applied if the process is completed
  • Using dpad button binds is redundant if axis binds were detected. The button binds should be skipped over if axis binds are applied successfully

@OpenSauce04 OpenSauce04 added enhancement New feature or request squash This pull request should be squashed if approved labels Mar 1, 2025
@OpenSauce04 OpenSauce04 marked this pull request as draft March 1, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request squash This pull request should be squashed if approved
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants