android: Add isEnabled setting item conditional check #595
+132
−43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kleidis
changed the title
|
Hiding options can make it difficult for users to find a setting if they are unaware that it may be hidden. This should only really be added if this implemented by greying out settings rather than hiding them. |
OpenSauce04
added
the
non-user-facing
|
By the way, I would recommend that the functionality for this should be implemented in this PR, and actually applying it to the relevant settings should be applied in a follow-up PR, hence the label. |
Co-authored-by: Charles Lombardo <[email protected]> (Thanks to him for the idea of using DiffUtil) Now it is possible to have a conditional check for each setting type which once met will disable itself and re-enable once the condition is unmet again in real-time
kleidis
force-pushed
the
android-diff-on-boolean-click
branch
from
7ec26ba to
a6553c8
Compare
kleidis
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now it is possible to have a conditional check for each setting type which once met will disable itself and re-enable once the condition is unmet again in real-time