Cleanup the isUnitSelf() method #108
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add `enum UnitFlag` to types for easier identification of the various flags that a unit can have. Add `isUnitPlayer()` to easier identify a player controlled unit. Refactor `isUnitSelf()` to make use of `isUnitPlayer()` and `UnitFlags`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
enum UnitFlagto types for easier identification of the various flags that a unit can have.Add
isUnitPlayer()to easier identify a player controlled unit.Refactor
isUnitSelf()to make use ofisUnitPlayer()andUnitFlags.To prove that nothing has change logically, the old
isUnitSelf()method checked the flags against the hexadecimal value 0x511 which consists of the flags:1297 decimal, 0x511 hex.