Add minimum encounter duration setting #107
Merged
+66
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Ignore the comment I made - it was made with some other code I've been looking at in mind, which isn't yet merged into main. Carry on! 😂 |
aza547
requested changes
Sep 16, 2022
…wow-recorder into feature/min-encounter-duration
|
Forgot to suggest that you add a changelog and some tests for this so just did that here: 9a9d60c. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a new setting to only keep videos for raid encounters longer than X seconds (excluding the additional overrun time). Defaults to 15 seconds.
Fixes #76