Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Only recording a sub-section of screen, probably detecting resolution wrongly? #96

Closed
aza547 opened this issue Sep 13, 2022 · 3 comments
Closed

Only recording a sub-section of screen, probably detecting resolution wrongly? #96

aza547 opened this issue Sep 13, 2022 · 3 comments
Labels
bug Something isn't working

Comments

@aza547
Copy link
Owner

aza547 commented Sep 13, 2022

Issue from MrFlyingBananas on discord.

image

WarcraftRecorder-2022-09-13.log
@aza547 aza547 changed the title Only recording half of screen Only recording a sub-section of screen, probably detecting resolution wrongly? Sep 13, 2022
@aza547 aza547 added the bug Something isn't working label Sep 13, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 14, 2022

image

NickIs211 added a commit to NickIs211/wow-recorder that referenced this issue Sep 15, 2022
@NickIs211
Added comment about getVersion during development. PR Also addresses a…
b7623ba 
…za547#96
@aza547 aza547 mentioned this issue Sep 18, 2022
Closed
NickIs211 added a commit to NickIs211/wow-recorder that referenced this issue Sep 18, 2022
@NickIs211
Added comment about getVersion during development. PR Also addresses a…
d2902dd 
…za547#96
aza547 pushed a commit that referenced this issue Sep 18, 2022
@NickIs211
Partial recorder bug (#113)
baaaa67 
* Fixed partial recording on displays with non-whole scale numbers

* added version to title bar

* version bump

* Added comment about getVersion during development. PR Also addresses #96

* Rewrote checkRes code based on github review

* changed obsRecorder.setupScene to use getAvailableValues and setSetting

* refactored resolution finding for scene

* removed version bump

* added changelog line
@aza547
Copy link
Owner Author

aza547 commented Sep 19, 2022

Fixed in next release.

@aza547 aza547 closed this as completed Sep 19, 2022
@aza547
Copy link
Owner Author

aza547 commented Sep 23, 2022

Re-opening this because I spotted this in passing and might be a better solution:
https://github.com/Envek/obs-studio-node-example/pull/16/files

@aza547 aza547 reopened this Sep 23, 2022
@aza547 aza547 closed this as completed Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aza547