Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3821: Make the # link stays at the current page #3933

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

Closes #3821: Make the # link stays at the current page #3933

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3b112a4
fix: make the # link stays at the current page
BaoNguyen09 Dec 9, 2024
69fb542
fix: Add newline after closing brace
BaoNguyen09 Dec 9, 2024
3606c6e
fix: remove a whitespace after closing brace
BaoNguyen09 Dec 9, 2024
76c1487
Merge branch 'main' into 3821-the-link-now-goes-to-the-homepage-inste…
BaoNguyen09 Dec 9, 2024
cb0da7d
feat: solve this issue for all anchor links
BaoNguyen09 Dec 11, 2024
05fce8a
Merge remote-tracking branch 'origin/3821-the-link-now-goes-to-the-ho…
BaoNguyen09 Dec 11, 2024
b8e3791
Update modules/custom/az_card/src/Plugin/Field/FieldFormatter/AZCardD…
BaoNguyen09 Dec 11, 2024
2a316b3
Merge branch 'main' into 3821-the-link-now-goes-to-the-homepage-inste…
BaoNguyen09 Dec 16, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 8 additions & 1 deletion modules/custom/az_card/src/Plugin/Field/FieldFormatter/AZCardDefaultFormatter.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,13 +125,20 @@ public function viewElements(FieldItemListInterface $items, $langcode) {
// Link.
$link_render_array = [];
$link_url = '';
$current_path = \Drupal::service('path.current')->getPath();
if ($item->link_title || $item->link_uri) {
if (str_starts_with($item->link_uri ?? '', '/' . PublicStream::basePath())) {
// Link to public file: use fromUri() to get the URL.
$link_url = Url::fromUri(urldecode('base:' . $item->link_uri));
}
else {
$link_url = $this->pathValidator->getUrlIfValid($item->link_uri ?? '<none>');
// Check if the link is an anchor within the current page.
if (str_starts_with($item->link_uri, "#")) {
$link_url = $this->pathValidator->getUrlIfValid($current_path . $item->link_uri);
}
else {
$link_url = $this->pathValidator->getUrlIfValid($item->link_uri ?? '<none>');
}
}
$link_render_array = [
'#type' => 'link',
Expand Down
Loading