Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3644: Add schema_metatag global defaults using the az_seo module #3901

Open
wants to merge 10 commits into
base: main
Choose a base branch
from

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Nov 21, 2024

Description

Release notes

AZ SEO now provides default global metatag settings to associate Quickstart websites with the University of Arizona via Schema.org metadata.

Related issues

How to test

  • Install AZ SEO, inspect meta tags on all pages.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joeparsons joeparsons changed the base branch from main to 3903-add-schema_metatag-module-to-quickstarts-composer-file-and-as-a-dependency-for-az_seo November 21, 2024 20:46
…file-and-as-a-dependency-for-az_seo' into issue/3644-alt
@joeparsons joeparsons changed the title Alternate PR for #3644: Adds schema_metatag module + patch from d.o. MR. Alternate PR for #3644: Adds schema_metatag patch from d.o. MR. Nov 21, 2024
@joeparsons joeparsons linked an issue Nov 21, 2024 that may be closed by this pull request
4 tasks
@trackleft
Copy link
Member

I think this PR should enable schema_organization and set global defaults.

Base automatically changed from 3903-add-schema_metatag-module-to-quickstarts-composer-file-and-as-a-dependency-for-az_seo to main November 22, 2024 18:13
@trackleft
Copy link
Member

Recommended metatag.metatag_defaults.global.yml

langcode: en
status: true
dependencies: {  }
id: global
label: Global
tags:
  canonical_url: '[current-page:url]'
  schema_organization_name: '[site:name]'
  schema_organization_parent_organization: 'a:6:{s:5:"@type";s:23:"EducationalOrganization";s:3:"@id";s:24:"https://www.arizona.edu/";s:4:"name";s:21:"University of Arizona";s:3:"url";s:24:"https://www.arizona.edu/";s:6:"sameAs";s:240:"https://www.facebook.com/uarizona,https://x.com/uarizona,https://www.instagram.com/uarizona,https://linkedin.com/edu/university-of-arizona-17783,https://www.youtube.com/universityofarizona,https://en.wikipedia.org/wiki/University_of_Arizona";s:7:"address";a:6:{s:5:"@type";s:13:"PostalAddress";s:13:"streetAddress";s:22:"1200 E University Blvd";s:15:"addressLocality";s:6:"Tucson";s:13:"addressRegion";s:2:"AZ";s:10:"postalCode";s:5:"85721";s:14:"addressCountry";s:2:"US";}}'
  title: '[current-page:title] | [site:name]'

RyanDool
RyanDool previously approved these changes Dec 6, 2024
@RyanDool
Copy link
Contributor

RyanDool commented Dec 6, 2024

Recommended metatag.metatag_defaults.global.yml

langcode: en
status: true
dependencies: {  }
id: global
label: Global
tags:
  canonical_url: '[current-page:url]'
  schema_organization_name: '[site:name]'
  schema_organization_parent_organization: 'a:6:{s:5:"@type";s:23:"EducationalOrganization";s:3:"@id";s:24:"https://www.arizona.edu/";s:4:"name";s:21:"University of Arizona";s:3:"url";s:24:"https://www.arizona.edu/";s:6:"sameAs";s:240:"https://www.facebook.com/uarizona,https://x.com/uarizona,https://www.instagram.com/uarizona,https://linkedin.com/edu/university-of-arizona-17783,https://www.youtube.com/universityofarizona,https://en.wikipedia.org/wiki/University_of_Arizona";s:7:"address";a:6:{s:5:"@type";s:13:"PostalAddress";s:13:"streetAddress";s:22:"1200 E University Blvd";s:15:"addressLocality";s:6:"Tucson";s:13:"addressRegion";s:2:"AZ";s:10:"postalCode";s:5:"85721";s:14:"addressCountry";s:2:"US";}}'
  title: '[current-page:title] | [site:name]'

I agree that should be done. Maybe not in this PR since its out of scope of the original request but it should definitely be done

@trackleft
Copy link
Member

Spoke with the module maintainer via slack:
image

@joeparsons joeparsons changed the title Alternate PR for #3644: Adds schema_metatag patch from d.o. MR. Closes #3644: Add schema_metatag global defaults using the az_seo module Feb 28, 2025
@joeparsons joeparsons marked this pull request as ready for review February 28, 2025 22:12
@joeparsons joeparsons requested a review from a team as a code owner February 28, 2025 22:12
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

<script type="application/ld+json">
{
	"@context": "https://schema.org/",
	"@type": "CollegeOrUniversity",
	"name": "University of Arizona {{Department/College}}",
	"url": "{{Department/College url}}",
	"description": "{{Description of department/college}}",
	"logo": "{{Department/College logo}}",
	"image": "{{Image to represent department/college}}",
	"sameAs": "{{comma separated social media URLs}}",
	"address": {
		"@type": "PostalAddress",
		"streetAddress": "{{Street Address}}",
		"addressLocality": "{{City}}",
		"addressRegion": "{{2 letter state abbreviation}}",
		"postalCode": "{{5 digits}}",
		"addressCountry": "{{Country abbreviation}}"
	},
	"telephone": "{{+1-555-555-5555}}",
	"email": "{{Department/College email address}}",
	"parentOrganization": {
		"@type": "EducationalOrganization",
		"name": "University of Arizona",
		"url": "https://www.arizona.edu/",
		"address": {
			"@type": "PostalAddress",
			"streetAddress": "1401 E University Blvd",
			"addressLocality": "Tucson",
			"addressRegion": "AZ",
			"postalCode": "85721",
			"addressCountry": "US"
		}
	}
}
</script>

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The address here vs the PR are different.
1401 E University Blvd vs 1200 E University Blvd

Copy link
Member

@trackleft trackleft Feb 28, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here is how I handled the following tokens
{{Department/College}} -> [site:name]
{{Department/College url}} -> [site:url]
{{Description of department/college}} -> [site:slogan]
{{Department/College logo}} ->
{{Image to represent department/college}} ->
{{Department/College email address}} ->
{{+1-555-555-5555}} ->
{{comma separated social media URLs}} ->
{{Street Address}} ->
{{City}} ->
{{2 letter state abbreviation}} ->
{{5 digits}} ->
{{Country abbreviation}} ->
{{+1-555-555-5555}} ->
{{Department/College email address}} ->

@trackleft
Copy link
Member

Some special character checking for pipes, commas, ampersands, apostrophes, hyphens and parentheses would be good.

@joeparsons joeparsons added needs-CWS-testing Needs manual pre/post release testing by Campus Web Services high priority Must get done for this milestone labels Mar 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.13.x only enhancement New feature or request high priority Must get done for this milestone needs-CWS-testing Needs manual pre/post release testing by Campus Web Services release notes
Projects
Status: Needs review
Development

Successfully merging this pull request may close these issues.

Set schema_metatag global defaults for az_quickstart Using the az_seo Module
4 participants