Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes #3852 Citation Style Group Rendering #3853

Merged
merged 2 commits into from
Nov 1, 2024
Merged

Fixes #3852 Citation Style Group Rendering #3853

merged 2 commits into from
Nov 1, 2024

Conversation

tadean
Copy link
Contributor

@tadean tadean commented Nov 1, 2024

Description

CSL Group elements operate as an implicit conditional and are intended to not display if child elements are empty. seboettg/citeproc-php presently has an issue where this conditional test fails for label elements. This can be seen in the APA style, where the unused number-of-volumes group is displayed for book-like citations:

Wildcat, W. (2024). History of Wildcats. In Wildcat Anthology (Version V1, 1–, Issues 4, pp. 200-230). The University of Arizona Press.

This PR adds a patch from the dev branch of seboettg/citeproc-php that causes groups with labels to not display if the label is empty.

Related issues

Fixes #3852

How to test

  • enable az_publication
  • set APA as the default citation style at /admin/config/az-quickstart/settings/az-publication
  • Create a BOOK publication
  • Set version to V1
  • Set pages to 15-20
  • Save publication
  • Verify the parenthetical information in the citation is (Version V1, pp. 15-20) and NOT (Version V1, 1–, pp. 15-20)

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@tadean tadean added patch release Issues to be included in the next patch release publications labels Nov 1, 2024
@tadean tadean requested a review from natebyerley November 1, 2024 01:22
@tadean tadean self-assigned this Nov 1, 2024
@tadean tadean requested a review from a team as a code owner November 1, 2024 01:22
@tadean
Copy link
Contributor Author

tadean commented Nov 1, 2024

This patch can likely be removed with the next stable release of seboettg/citeproc-php

@joeparsons joeparsons merged commit 82d999d into main Nov 1, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3852 branch November 1, 2024 17:39
@danahertzberg danahertzberg added the needs-CWS-testing Needs manual pre/post release testing by Campus Web Services label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-CWS-testing Needs manual pre/post release testing by Campus Web Services patch release Issues to be included in the next patch release publications
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Citation Style issue with Group Label Elements
4 participants