Fixes #3852 Citation Style Group Rendering #3853
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
CSL Group elements operate as an implicit conditional and are intended to not display if child elements are empty.
seboettg/citeproc-php
presently has an issue where this conditional test fails for label elements. This can be seen in the APA style, where the unusednumber-of-volumes
group is displayed for book-like citations:Wildcat, W. (2024). History of Wildcats. In Wildcat Anthology (Version V1, 1–, Issues 4, pp. 200-230). The University of Arizona Press.
This PR adds a patch from the dev branch of
seboettg/citeproc-php
that causes groups with labels to not display if the label is empty.Related issues
Fixes #3852
How to test
az_publication
/admin/config/az-quickstart/settings/az-publication
V1
15-20
(Version V1, pp. 15-20)
and NOT(Version V1, 1–, pp. 15-20)
Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist