Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3842 Content editors can now upload and use webp images with their content. #3843

Merged
merged 4 commits into from
Oct 30, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Oct 26, 2024

Description

Allow webp images for all image upload fields and allow searching and linking via linkit.

Related issues

Close #3842

How to test

Add or edit any content that has a media field that accepts images.
Change the theme logo
Add images within the ckeditor
Linking the image via linkit

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@trackleft trackleft linked an issue Oct 26, 2024 that may be closed by this pull request
@trackleft trackleft added release notes 2.12.x only documentation Improvements or additions to documentation labels Oct 29, 2024
@trackleft trackleft marked this pull request as ready for review October 29, 2024 16:00
@trackleft trackleft requested a review from a team as a code owner October 29, 2024 16:00
@trackleft trackleft changed the title Allow uploading webp images Close #3842 Content editors can now upload and use webp images with their content. Oct 29, 2024
@trackleft trackleft requested a review from natebyerley October 29, 2024 16:02
@joeparsons
Copy link
Member

Do you think it would make sense to include this change in a 2.11.x patch release?

@trackleft
Copy link
Member Author

trackleft commented Oct 29, 2024

Do you think it would make sense to include this change in a 2.11.x patch release?

yes

@joeparsons joeparsons added enhancement New feature or request patch release Issues to be included in the next patch release and removed 2.12.x only labels Oct 29, 2024
Copy link

@natebyerley natebyerley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I downloaded an image from the site, which came in as a .jpg.webp, then reuploaded the image to the site, and placed the image on a page - all steps succeeded.

@joeparsons joeparsons merged commit c28506a into main Oct 30, 2024
18 checks passed
@joeparsons joeparsons deleted the 3842-allow-uploading-webp-images branch October 30, 2024 17:15
bberndt-uaz pushed a commit that referenced this pull request Nov 1, 2024
joeparsons pushed a commit that referenced this pull request Nov 19, 2024
@danahertzberg danahertzberg added the needs-CWS-testing Needs manual pre/post release testing by Campus Web Services label Nov 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request needs-CWS-testing Needs manual pre/post release testing by Campus Web Services patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Allow uploading webp images
6 participants