Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3810 Remove version key from library definition files. #3811

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Oct 23, 2024

Description

Removing all version keys as we don't automatically update it.

Related issues

Close #3810

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@trackleft trackleft linked an issue Oct 23, 2024 that may be closed by this pull request
@trackleft trackleft marked this pull request as ready for review October 23, 2024 19:14
@trackleft trackleft requested a review from a team as a code owner October 23, 2024 19:14
@trackleft trackleft changed the title Close #3810 Remove version key from libraries. Close #3810 Remove version key from library definition files. Oct 23, 2024
@joeparsons joeparsons added bug Something isn't working patch release Issues to be included in the next patch release labels Oct 23, 2024
@joeparsons joeparsons merged commit 24cd9f6 into main Oct 25, 2024
18 checks passed
@joeparsons joeparsons deleted the 3810-remove-version-key-in-librariesyml-files branch October 25, 2024 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Remove version key in *.libraries.yml files.
4 participants