Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drupal/better_exposed_filters requirement from 7.0.1 to 7.0.2 #3771

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Oct 15, 2024

Updates the requirements on drupal/better_exposed_filters to permit the latest version.

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Updates the requirements on drupal/better_exposed_filters to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/better_exposed_filters
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner October 15, 2024 16:28
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Oct 15, 2024
@bberndt-uaz
Copy link
Contributor

https://www.drupal.org/project/better_exposed_filters/releases/7.0.2

Release notes

Changes since 7.0.1:

Bug

  • #3468358 by andre.bonon: Text fields are auto-submitted twice when...
  • #3469224: Nondescript error when trying to edit Exposed Form Style settings in view
  • #2756233 by gstivanin, JaceRider, jakub_89: Nested all/none selection weird behavior
  • #3469712 by sander wemagine: Remembered filters don't reset with BEF
  • #3468358: UPDATE 1 - Text fields are auto-submitted twice when filters are exposed as block
  • Resolve #3472881 "Local lobraries not"
  • Resolve #3299687 "Date input triggers"
  • #3478411: Altering the BEF options propagate properly.

Feature

Task

  • #3477417: Add warning to status page if external library nouislider does not exist.
  • Resolve #3262456 "Add minimum length"

@bberndt-uaz bberndt-uaz added Drupal Waiting on a fix from the Drupal community 2.12.x only labels Oct 15, 2024
bberndt-uaz
bberndt-uaz previously approved these changes Oct 18, 2024
@joeparsons
Copy link
Member

Release notes

The jquery_ui_touch_punch module has been deprecated as a Quickstart dependency and will be removed in a future minor release of Quickstart.  Sites owners should uninstall this module or add it to their site-specific composer.json files to continue using it.

@bberndt-uaz
Copy link
Contributor

See the previous Better Exposed Filters PR which updates it from 6.0.6 to 7.0.1 where we deprecated the NPM jquery-ui-touch-punch package. We did have release notes for that PR as well, so maybe we can combine that one with Joe's notes above.

@joeparsons
Copy link
Member

See the previous Better Exposed Filters PR which updates it from 6.0.6 to 7.0.1 where we deprecated the NPM jquery-ui-touch-punch package. We did have release notes for that PR as well, so maybe we can combine that one with Joe's notes above.

Good idea.

@bberndt-uaz
Copy link
Contributor

See the previous Better Exposed Filters PR which updates it from 6.0.6 to 7.0.1 where we deprecated the NPM jquery-ui-touch-punch package. We did have release notes for that PR as well, so maybe we can combine that one with Joe's notes above.

Good idea.

OK! I have combined the text of the two release notes and updated the note on #3662. Since we will use the release note from that PR, I have removed the label from this PR.

joeparsons
joeparsons previously approved these changes Oct 18, 2024
bberndt-uaz
bberndt-uaz previously approved these changes Oct 21, 2024
Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Applying this PR to an existing site was resulting in an error when trying to import configuration using config-distro-update:

Error: The import failed due to the following reasons:
Unable to install the jquery_ui_slider module since it does not exist.
Unable to install the jquery_ui_touch_punch module since it does not exist.

Adding jquery_ui_slider and jquery_ui_touch_punch to composer.json resolves this issue. See the Quickstart 2.12 release note for the previous Better Exposed Filters PR:

@joeparsons
Copy link
Member

Applying this PR to an existing site was resulting in an error when trying to import configuration using config-distro-update:

Error: The import failed due to the following reasons:
Unable to install the jquery_ui_slider module since it does not exist.
Unable to install the jquery_ui_touch_punch module since it does not exist.

Adding jquery_ui_slider and jquery_ui_touch_punch to composer.json resolves this issue. See the Quickstart 2.12 release note for the previous Better Exposed Filters PR:

Good catch. Thanks @bberndt-uaz!

joeparsons
joeparsons previously approved these changes Oct 21, 2024
@joeparsons joeparsons dismissed stale reviews from bberndt-uaz and themself via e047552 October 21, 2024 23:25
@joeparsons joeparsons merged commit fef8129 into main Oct 23, 2024
16 checks passed
@joeparsons joeparsons deleted the dependabot/composer/drupal/better_exposed_filters-7.0.2 branch October 23, 2024 17:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community php Pull requests that update Php code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants