Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3758: Ensure all external and minified library assets are properly configured. #3759

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Oct 8, 2024

Description

Addresses various discrepancies in various library definitions for external and already minified assets.

Related issues

Closes #3758

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@joeparsons joeparsons marked this pull request as ready for review October 8, 2024 19:55
@joeparsons joeparsons requested a review from a team as a code owner October 8, 2024 19:55
@joeparsons joeparsons self-assigned this Oct 8, 2024
@joeparsons joeparsons added bug Something isn't working 2.11.x only labels Oct 8, 2024
@trackleft trackleft merged commit 26cfead into main Oct 8, 2024
16 checks passed
@trackleft trackleft deleted the issue/3758-ensure-all-minified-library-assets-are-probably-configured branch October 8, 2024 23:09
@trackleft trackleft added the patch release Issues to be included in the next patch release label Oct 15, 2024
joeparsons added a commit that referenced this pull request Oct 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only bug Something isn't working patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Ensure all external and minified library assets are properly configured
3 participants