Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3714 Extra main landmark role in page template #3715

Merged
merged 1 commit into from
Sep 20, 2024
Merged

Conversation

bberndt-uaz
Copy link
Contributor

@bberndt-uaz bberndt-uaz commented Sep 12, 2024

Description

This PR removes the extra role="main" from the AZ Barrio page template since there should only be one main role on a page.

Release notes

Note: This release removes div[role=main] from every page since a <main> element already exists with that role. If your site's CSS or JS depend on this landmark to function, you'll need to target that div in another way.

Related issues

How to test

Probo review site: https://7b5e2985-cedf-4a13-ab91-3a35916c835d--pr-3715.probo.build/

Confirm that pages on the review site only have one instance of role="main" in the source.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@bberndt-uaz bberndt-uaz added bug Something isn't working accessibility labels Sep 12, 2024
@bberndt-uaz bberndt-uaz self-assigned this Sep 12, 2024
@bberndt-uaz bberndt-uaz linked an issue Sep 12, 2024 that may be closed by this pull request
@bberndt-uaz bberndt-uaz marked this pull request as ready for review September 13, 2024 16:29
@bberndt-uaz bberndt-uaz requested a review from a team as a code owner September 13, 2024 16:29
Copy link
Contributor

@danahertzberg danahertzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me. I would also like to get @accesswatch's review on this one.

@bberndt-uaz bberndt-uaz added the patch release Issues to be included in the next patch release label Sep 20, 2024
@trackleft trackleft merged commit b9cc5ee into main Sep 20, 2024
16 checks passed
@trackleft trackleft deleted the issue/3714 branch September 20, 2024 17:44
@bberndt-uaz
Copy link
Contributor Author

@accesswatch approved this during our AZ Digital Friday meeting today.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
accessibility bug Something isn't working patch release Issues to be included in the next patch release release notes
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Extra main landmark role in page template
5 participants