Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close #3683 use migmag_lookup instead of migrate_lookup #3684

Merged
merged 5 commits into from
Sep 11, 2024
Merged

Conversation

trackleft
Copy link
Member

@trackleft trackleft commented Sep 3, 2024

Description

Swapping migration lookup plugin from core's migrate_lookup for migrate magician module's migmag_lookup.

Release notes

Migrate magician is now a hard dependency of the az_migration module. If you've previously enabled az_migration, you should already have migrate magician process enabled (`migmag_process`)

Related issues

Closes #3683

How to test

Migrate from Drupal 7 site (UA Quickstart) and see if everything migrates successfully.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@trackleft trackleft requested a review from a team as a code owner September 3, 2024 18:51
@joeparsons joeparsons added enhancement New feature or request migration Related to the D7 to D9 migration patch release Issues to be included in the next patch release labels Sep 3, 2024
@joeparsons
Copy link
Member

I think it'd probably be worth adding a DB update function that installs the new module dependency on existing sites.

@joeparsons joeparsons merged commit 19e4230 into main Sep 11, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3683 branch September 11, 2024 21:52
This was referenced Sep 12, 2024
@trackleft trackleft added the backport Changes to be back-ported to previous minor release branch label Sep 12, 2024
joeparsons added a commit that referenced this pull request Sep 12, 2024
joeparsons added a commit that referenced this pull request Sep 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch enhancement New feature or request migration Related to the D7 to D9 migration patch release Issues to be included in the next patch release
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Use the migration_lookup plugin from the migrate magician module instead of the one included in core.
3 participants