Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drupal/bootstrap_barrio requirement from 5.1.10 to 5.1.12 #3681

Merged
merged 5 commits into from
Oct 25, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Sep 2, 2024

Updates the requirements on drupal/bootstrap_barrio to permit the latest version.

Most Recent Ignore Conditions Applied to This Pull Request
Dependency Name Ignore Conditions
drupal/bootstrap_barrio [> 4.30]

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on drupal/bootstrap_barrio to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/bootstrap_barrio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner September 2, 2024 22:20
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Sep 2, 2024
@joeparsons
Copy link
Member

joeparsons commented Sep 3, 2024

@joeparsons
Copy link
Member

Failed Probo "Check for PHP errors and notices" check is related to this issue:
https://www.drupal.org/project/bootstrap_barrio/issues/3471821

@joeparsons joeparsons added Drupal Waiting on a fix from the Drupal community 2.11.x only labels Sep 3, 2024
@joeparsons joeparsons changed the title Update drupal/bootstrap_barrio requirement from 5.1.10 to 5.1.11 Update drupal/bootstrap_barrio requirement from 5.1.10 to 5.1.12 Sep 4, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github Sep 4, 2024

A newer version of drupal/bootstrap_barrio exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

@joshuasosa
Copy link
Contributor

joshuasosa commented Oct 8, 2024

Alert messages are unstyled as of Drupal 10.3. Bootstrap Barrio 5.1.12 with this commit seems to mostly fix it.

            "drupal/bootstrap_barrio": {
                "Fix The specified library bootstrap_barrio/messages does not exist issue (3471821)": "https://git.drupalcode.org/project/bootstrap_barrio/-/commit/a26e7af7c007aced43f0347553104434d11e3681.patch"
            }

Hopefully the fix will be included in 5.1.13.

@joeparsons
Copy link
Member

joeparsons commented Oct 9, 2024

Alert messages are unstyled as of Drupal 10.3. Bootstrap Barrio 5.1.12 with this commit seems to mostly fix it.

            "drupal/bootstrap_barrio": {
                "Fix The specified library bootstrap_barrio/messages does not exist issue (3471821)": "https://git.drupalcode.org/project/bootstrap_barrio/-/commit/a26e7af7c007aced43f0347553104434d11e3681.patch"
            }

Hopefully the fix will be included in 5.1.13.

Cool. Will add that patch to this PR. Thanks @joshuasosa! Sounds like it might provide at least a partial fix for #3516 🤞🏻.

Copy link
Contributor

@joshuasosa joshuasosa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested patch by clicking the search box button without input (i.e., visit /search/node?keys=) under both authenticated and anonymous.

Copy link
Contributor

@bberndt-uaz bberndt-uaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I did some general testing in Probo and didn't notice any issues.

@joeparsons joeparsons merged commit 62e03a7 into main Oct 25, 2024
16 checks passed
@joeparsons joeparsons deleted the dependabot/composer/drupal/bootstrap_barrio-5.1.11 branch October 25, 2024 21:15
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Oct 25, 2024
bberndt-uaz pushed a commit that referenced this pull request Nov 1, 2024
* Update drupal/bootstrap_barrio requirement from 5.1.10 to 5.1.11

Updates the requirements on drupal/bootstrap_barrio to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/bootstrap_barrio
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>

* Remove no-longer-needed patch for https://www.drupal.org/project/bootstrap_barrio/issues/3366908

* Update to 5.1.12

* Add message styling patch.

---------

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Joe Parsons <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community patch release Issues to be included in the next patch release php Pull requests that update Php code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants