Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3576 Add new demo AZ News node with embedded media and extra paragraphs #3631

Merged
merged 5 commits into from
Aug 23, 2024

Conversation

djcelaya
Copy link
Contributor

@djcelaya djcelaya commented Aug 12, 2024

Description

Introduces a new AZ News demo node that contains an embedded media (image) item and two "Extra Page Elements" paragraphs. This press release is modeled after one of the news release we've produced in UAHS Communications, but I've replaced all references to UAHS with fake data that ChatGPT produced.

Related issues

#3576

How to test

  1. Create a new AZ Quickstart site
  2. Run drush pm:install az_demo. This will install demo content, including the new AZ News node with embedded images and additional paragraphs.
  3. Navigate to /news/university-arizona-unveils-pioneering-treatment-type-1-diabetes-game-changer-patients. The new AZ News item should look like:
Screenshot 2024-08-12 at 3 33 45 PM Screenshot 2024-08-12 at 3 34 07 PM

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@djcelaya djcelaya self-assigned this Aug 12, 2024
@djcelaya djcelaya linked an issue Aug 12, 2024 that may be closed by this pull request
@joeparsons joeparsons added enhancement New feature or request ci Continuous integration / automation labels Aug 13, 2024
@djcelaya
Copy link
Contributor Author

I've noticed the exceedingly large vertical space under the embedded image's caption and credit area. I was not expecting that spacing problem to be this extreme but if I add another embedded image (that was not introduced with this PR) and adjust it to have a credit field, the same spacing behavior appears. I will explore correcting that problem in a follow up issue unless we feel that something I've done here has introduced this undesirable behavior.

@djcelaya djcelaya marked this pull request as ready for review August 14, 2024 21:44
@djcelaya djcelaya requested a review from a team as a code owner August 14, 2024 21:44
@joeparsons joeparsons changed the title Add new demo AZ News node with embedded media and extra paragraphs Closes #3576 Add new demo AZ News node with embedded media and extra paragraphs Aug 15, 2024
@joeparsons
Copy link
Member

Direct link to page with updated demo content on ProboCI build for PR:
https://a6f91014-dbd8-4f1e-96cb-ca20299cb2f2.probo.build/news/university-arizona-unveils-pioneering-treatment-type-1-diabetes-game-changer-patients

danahertzberg
danahertzberg previously approved these changes Aug 16, 2024
trackleft
trackleft previously approved these changes Aug 16, 2024
@djcelaya
Copy link
Contributor Author

Per our discussion today, I will replace [email protected] with [email protected] in case there's ever a legit Rachel Thompson here. I will also find better placeholder images on Adobe Stock or the DAM to be more consistent with our other demo content that has "real" images.

@djcelaya djcelaya dismissed stale reviews from trackleft and danahertzberg via 0cd99de August 16, 2024 22:18
@trackleft trackleft added backport Changes to be back-ported to previous minor release branch and removed backport Changes to be back-ported to previous minor release branch labels Aug 16, 2024
@djcelaya
Copy link
Contributor Author

FYI, press release initially generated by ChatGPT and modeled after: https://healthsciences.arizona.edu/news/releases/bhattacharya-named-inaugural-executive-director-cami

trackleft
trackleft previously approved these changes Aug 16, 2024
camikazegreen
camikazegreen previously approved these changes Aug 16, 2024
Copy link
Contributor

@camikazegreen camikazegreen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This demo content looks great

joeparsons
joeparsons previously approved these changes Aug 19, 2024
@djcelaya djcelaya dismissed stale reviews from camikazegreen and trackleft via 1447151 August 21, 2024 21:20
Copy link
Contributor

@danahertzberg danahertzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think definitely a separate ticket. But the caption/credit on the image in the body field has 2 extra blank paragraphs adding extra space to it.

#3439

@joeparsons joeparsons merged commit c4ffb88 into main Aug 23, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3576 branch August 23, 2024 17:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.12.x only ci Continuous integration / automation enhancement New feature or request
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add demo content to test media embed displays
5 participants