-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes #3576 Add new demo AZ News node with embedded media and extra paragraphs #3631
Conversation
I've noticed the exceedingly large vertical space under the embedded image's caption and credit area. I was not expecting that spacing problem to be this extreme but if I add another embedded image (that was not introduced with this PR) and adjust it to have a credit field, the same spacing behavior appears. I will explore correcting that problem in a follow up issue unless we feel that something I've done here has introduced this undesirable behavior. |
Direct link to page with updated demo content on ProboCI build for PR: |
Per our discussion today, I will replace [email protected] with [email protected] in case there's ever a legit Rachel Thompson here. I will also find better placeholder images on Adobe Stock or the DAM to be more consistent with our other demo content that has "real" images. |
FYI, press release initially generated by ChatGPT and modeled after: https://healthsciences.arizona.edu/news/releases/bhattacharya-named-inaugural-executive-director-cami |
List view of news stories: https://a827580c-a656-4fb5-823e-4b29a520b5cb.probo.build/news |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This demo content looks great
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think definitely a separate ticket. But the caption/credit on the image in the body field has 2 extra blank paragraphs adding extra space to it.
Description
Introduces a new AZ News demo node that contains an embedded media (image) item and two "Extra Page Elements" paragraphs. This press release is modeled after one of the news release we've produced in UAHS Communications, but I've replaced all references to UAHS with fake data that ChatGPT produced.
Related issues
#3576
How to test
drush pm:install az_demo
. This will install demo content, including the new AZ News node with embedded images and additional paragraphs./news/university-arizona-unveils-pioneering-treatment-type-1-diabetes-game-changer-patients
. The new AZ News item should look like:Types of changes
Arizona Quickstart (install profile, custom modules, custom theme)
Drupal core
Drupal contrib projects
Checklist