Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3453 | Remove duplicate required asterisk on Webforms #3519

Merged
merged 1 commit into from
Jul 3, 2024

Conversation

akslay
Copy link
Contributor

@akslay akslay commented Jul 1, 2024

Description

Corrects duplicate asterisks on required multi-select fields (i.e., checkboxes, radios, checkboxes other, radios other).

Related issues

Closes #3453

How to test

  1. Install Webform & Webform UI.
  2. Build a Webform with different types of fields.
    Be sure to include some multi-select field types, and mark them as required.
  3. View the Webform and verify that multi-select fields no longer have a duplicate asterisk.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • My change requires release notes.

@akslay akslay added the bug Something isn't working label Jul 1, 2024
@akslay akslay self-assigned this Jul 1, 2024
@akslay akslay requested a review from a team as a code owner July 1, 2024 22:16
@joeparsons joeparsons added backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release labels Jul 2, 2024
Copy link
Member

@joeparsons joeparsons left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks!

@joeparsons joeparsons added the visual change Introduces a visual change label Jul 2, 2024
@joeparsons joeparsons merged commit c2fe0f9 into main Jul 3, 2024
16 checks passed
@joeparsons joeparsons deleted the issue/3453 branch July 3, 2024 17:26
This was referenced Jul 26, 2024
@joeparsons joeparsons removed the backport Changes to be back-ported to previous minor release branch label Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release visual change Introduces a visual change
Projects
No open projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

Webform | Multi-select fields receiving duplicate required asterisks
5 participants