Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3174. Made text area not required on az_text_background. #3392

Merged
merged 1 commit into from
May 3, 2024

Conversation

mrbeiley
Copy link
Contributor

@mrbeiley mrbeiley commented May 1, 2024

Remove requirement of text area, in order to create banners of color without any text. These elements are just to add space to a page. Still allows users to add Text with Backgrounds.

Description

Closes #3174

Related issues

Closes #3174

How to test

Create Text with Background elements that include text and don't include text. Make sure both elements appear as expected and don't cause any issues.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@mrbeiley mrbeiley requested a review from a team as a code owner May 1, 2024 21:50
@trackleft trackleft added enhancement New feature or request good first issue Good for newcomers editor experience Improvements to the editor experience for individuals editing Quickstart websites user experience Improvements to user experience 2.11.x only and removed user experience Improvements to user experience labels May 1, 2024
@trackleft trackleft requested review from JoeLutovsky, sanjanans, natebyerley and a team May 1, 2024 21:54
Copy link

@sanjanans sanjanans left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wonderful feature. Content admins/editor can really use them well to improve the site.

Copy link
Contributor

@danahertzberg danahertzberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@danahertzberg
Copy link
Contributor

Need followup issues to potentially:

  • Rename this paragraph type?
  • Add help text that is more contextual
  • Documentation update

@joeparsons joeparsons merged commit 738281e into main May 3, 2024
15 checks passed
@joeparsons joeparsons deleted the issue/3174 branch May 3, 2024 17:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only editor experience Improvements to the editor experience for individuals editing Quickstart websites enhancement New feature or request good first issue Good for newcomers
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Color Block Page Element
6 participants