Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update drupal/smart_date requirement from 4.0.3 to 4.1.3 #3386

Merged
merged 3 commits into from
Jun 3, 2024

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Apr 29, 2024

Updates the requirements on drupal/smart_date to permit the latest version.

You can trigger a rebase of this PR by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Note
Automatic rebases have been disabled on this pull request as it has been open for over 30 days.

Updates the requirements on drupal/smart_date to permit the latest version.

---
updated-dependencies:
- dependency-name: drupal/smart_date
  dependency-type: direct:production
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot requested a review from a team as a code owner April 29, 2024 22:49
@dependabot dependabot bot added dependencies Pull requests that update a dependency file php Pull requests that update Php code labels Apr 29, 2024
@bberndt-uaz
Copy link
Contributor

https://www.drupal.org/project/smart_date/releases/4.1.1

Release notes

A quick patch release to resolve an error in the previous 4.1.0 release.

Changes since 4.1.0:

Bug

  • #3443956 by jurgenhaas, mandclu: Drupal\smart_date_recur\Plugin\QueueWorker\RecurRuleUpdate::__construct(): Argument #1 ($entityTypeManager) must be of type Drupal\Core\Entity\EntityTypeManagerInterface, array given

https://www.drupal.org/project/smart_date/releases/4.1.0

Release notes

This initial, stable release for the 4.1.x branch features a number of improvements. The functional differences from the previous 4.1.0-rc9 release should be modest, including additional validation to ensure the repeat end date is after the provided start date. There was some significant code refactoring in order to make Smart Date pass eslint, phpcs, and phpstan, which are all now required to pass for contributions moving forward.

Changes since 4.0.3 include full resolution of the 2038 bug, expanded duration values to allow Smart Date to handle date ranges of over 4,000 years, and more views filter operators, so more sophisticated views can be created in less effort.

More importantly, the 4.1.0 makes Smart Date fully ready for Drupal 11, but thanks to some code by Matt Glaman and Drupal's deprecationHelper class, it doesn't come at the expense of backwards compatibility.

Changes since 4.0.3:

Bug

  • #3304395 by mandclu: Far-future dates cause WSOD, "Numeric value out of range"
  • #3379023 by MukhtarM: Schema errors while doing unit test on SmartDateTimezoneWidgetTest
  • #3382603 by mandclu: Cron in smart_date_recur not working due to property_exists
  • #3381131: Creation of dynamic property Drupal\smart_date\Plugin\views\filter\Date::$dateFormatter is deprecated
  • #3382670 by mandclu: foreach() argument must be of type array|object, bool given
  • #3379841: Text alignment issue
  • #3322456 by mandclu, hhvardan: The "Add another item" button does not work with a single click
  • #3399924 by mandclu: Smart Date fields look wonky with latest Gin release
  • #3399016 by gena.io, mandclu: Call to a member function toArray() on bool in Drupal\smart_date_recur\Plugin\QueueWorker\RecurRuleUpdate->processItem()
  • #3314791 by jrockowitz, codebymikey: "current_upcoming" as well as other config schema is missing
  • #3399865 by codebymikey, mandclu: Recurring formatter: fatal error when rendering by minutes or hourly
  • #3405129 by Igor Mashevskyi, mandclu: Wrong parent entity if use recurring date inside inline form
  • #3433115 by mandclu: Resolve test errors
  • #3435845 by mandclu: Error: The value you selected is not a valid choice
  • #3438857 by mandclu: Manage Instances throws fatal error
  • #3386133 by mandclu: node.field_[name] field needs to be updated
  • #3433267 by matthieuscarset: Smart date value custom format tokens empty
  • #3390714 by mandclu: Smart Date Range: Duration of >=16 years throws WSOD
  • #3443173 by jurgenhaas: Left behind debug command in RC8
  • #3413612 by mkinnune, mandclu: The repeat end date should not be allowed to come before the start time
  • #3426738 by mandclu, joewhitsitt: is_numeric check after augmentOutput() fails for core date field type using smart date formatter

Feature

  • #3390428 by mandclu, codebymikey: Improve recurring theming: Show the end time and don't show the day during daily reoccurences
  • #3403850 by mandclu: Allow recurring formatter to express days of the week as ranges
  • #3410547 by jurgenhaas, mandclu: New views filter operators for date range containing, starting or ending at giving value
  • #3406232 by mandclu: Add validation checks for start, end, and duration

Task

  • #3409287 by mglaman, mandclu, sidharth_soman: Deprecation in Drupal 10.2: Smart Date List Item allowed values must be passed as array
  • #3374428: system_time_zones() is deprecated in drupal:10.1.0
  • #3433051 by lostcarpark, mandclu, BenStallings: Add Gitlab CI
  • #3433214: GitLab CI - Stylelint fixes
  • #3433215: GitLab CI - ESLint - camel case variables
  • #3436045: Gitlab CI - Add module dictionary and resolve outstanding cspell issues
  • #3433216: GitLab CI - PHPCS - NoSpaceBefore and NoSpaceAfter
  • #3436008: GitLab CI - ESLint - "==" and "!="
  • #3432819 by chadhester, nicxvan, ultimike: Test for a later start date in a date range
  • #3434647 by Project Update Bot, mandclu: Automated Drupal 11 compatibility fixes for smart_date
  • #3370895 by Jasjeet Kaur Brar, roshni27, mandclu: \Drupal calls should be avoided in classes, use dependency injection instead
  • #3437669 by lostcarpark, mandclu: GitLab CI - ESLint - no-var and prefer-const
  • #3439011 by lostcarpark: GitLab CI - PHPCS - Long lines and whitespace errors
  • #3443478 by mandclu: Clean up CI failures
  • #3443414 by mandclu: Gitlab CI: Clean up PHPCS and CSPELL errors, require pass
  • #3443508 by mandclu: Gitlab CI: Clean up ESLint errors and warnings, require success
  • #3443555 by mandclu: Clean up PHPStan errors, require success

@bberndt-uaz
Copy link
Contributor

I added a commit to remove the patches for issues #3381131 and #3409287 since that code was included in 4.1.0.

@joeparsons joeparsons added the Drupal Waiting on a fix from the Drupal community label Apr 30, 2024
@joeparsons
Copy link
Member

Based on what I'm seeing in the release notes, 4.1.x shouldn't be introducing any backwards incompatible changes so it should be safe to upgrade (in theory) even in a Quickstart patch release. We'll definitely want to do some testing, though.

joeparsons
joeparsons previously approved these changes May 3, 2024
Copy link
Contributor Author

dependabot bot commented on behalf of github May 6, 2024

A newer version of drupal/smart_date exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

trackleft
trackleft previously approved these changes May 10, 2024
composer.json Outdated Show resolved Hide resolved
@trackleft trackleft dismissed stale reviews from joeparsons and themself via 14f2504 May 31, 2024 20:08
@trackleft
Copy link
Member

Changes since 4.1.1:

Bug
#3444046 by mandclu: Warning: Undefined array key "time_wrapper"
#3440576 by pablo.fredes, mandclu: TypeError: explode(): Argument #2 ($string) must be of type string, array given in explode()
#3423255 by abhishek_gupta1, mandclu: Error in fullcalendar_view for Smart date range if Allowed number of values ​is ​1
#3444258 by mandclu, esomething: getParentEntity in SmartDateRule Preventing New Instance Creation
#3354858 by mandclu, DieterHolvoet, codechefmarc, Odai Atieh: Warning: Trying to access array offset on value of type null

@trackleft
Copy link
Member

Changes since 4.1.2:

Bug
#3444283 by mandclu: Hide seconds causes warning
#3447311 by mandclu: PhpStan errors on drush classes
#3447289 by Sweetchuck, mandclu: links.task refers to non existing base_route smart_date.settings
#3448341 by mandclu: [error] TypeError: Drupal\smart_date_recur\Drush\Commands\SmartDateRecurCommands::__construct(): Argument #2 ($entityTypeManager) must be of type Drupal\Core\Entity\EntityTypeManagerInterface

@trackleft
Copy link
Member

@trackleft trackleft requested a review from joeparsons May 31, 2024 20:10
@joeparsons joeparsons changed the title Update drupal/smart_date requirement from 4.0.3 to 4.1.1 Update drupal/smart_date requirement from 4.0.3 to 4.1.3 Jun 3, 2024
@joeparsons joeparsons merged commit 5d91fe2 into main Jun 3, 2024
15 checks passed
@joeparsons joeparsons deleted the dependabot/composer/drupal/smart_date-4.1.1 branch June 3, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
2.11.x only dependencies Pull requests that update a dependency file Drupal Waiting on a fix from the Drupal community php Pull requests that update Php code
Projects
No open projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants