Closes #3096 Simple file system configuration change to sanitize uploaded filenames.

[maine-inventor]

Description

Related issues

#3096

How to test

Add any node content that contains a media file field.
Select file upload and select a local image file with a whacky file name ( spaces, special characters)
[upload]
Observe the new file name all cleaned up. Example: spaces are now "-"s.
Also test the replacing of document files while preserving the filename (using the functionality from the Media Entity File Replace module).
Updated: Uploaded file character casing remains untouched.

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

• Patch release changes
  • Bug fix
  • Accessibility, performance, or security improvement
  • Critical institutional link or brand change
  • Adding experimental module
  • Update experimental module
• Minor release changes
  • New feature
  • Breaking or visual change to existing behavior
  • Upgrade experimental module to stable
  • Enable existing module by default or database update
  • Non-critical brand change
  • New internal API or API improvement with backwards compatibility
  • Risky or disruptive cleanup to comply with coding standards
  • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
• Other or unknown
  • Other or unknown

Drupal core

• Patch release changes
  • Security update
  • Patch level release (non-security bug-fix release)
  • Patch removal that's no longer necessary
• Minor release changes
  • Major or minor level update
• Other or unknown
  • Other or unknown

Drupal contrib projects

• Patch release changes
  • Security update
  • Patch or minor level update
  • Add new module
  • Patch removal that's no longer necessary
• Minor release changes
  • Major level update
• Other or unknown
  • Other or unknown

Checklist

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[bberndt-uaz]

Do we want to enable all the "Sanitize filenames" settings? I'm wondering in particular about the "Convert to lowercase" setting.

[trackleft]

Please commit the suggestion here: #3180 (comment)

Please convert this PR from a draft

To ready for review

[joeparsons]

Do we want to enable all the "Sanitize filenames" settings? I'm wondering in particular about the "Convert to lowercase" setting.

I do think it would be good to enable these settings by default on new site installs. We don't necessarily want to enable these settings on existing sites though.

[joeparsons]

I was thinking we did this in Quickstart 1 but it looks like all we did was include the contrib Transliteration module but it wasn't installed by default. When that module was installed on Quickstart 1 its default settings basically match what is in this PR.

[maine-inventor]

Tested multiple filename patterns for upload(space, dash, underscore) , works as described

[danahertzberg]

Check if this needs to be in the Quickstart folder. Test against existing site to ensure compatibility.

This is not a retroactive change. Will only work with new file uploads after this is merged.

[trackleft]

Tested this, and it appears to apply the configuration update on sites that existed before this setting existed.

Site that I tested on began its life in drupal core 10.1.7
The setting edited in this PR was introduced in Drupal core 10.2.x

[danahertzberg]

Look into:

• Having case not be a distinguisher of files (eee.pdf and EEE.pdf should be the same file)
  - Having a title field so PDFs can be displayed with spaces, etc. Separate issue Add title field to document media type. #3448

[maine-inventor]

Updated the character casing check to not force to lower.