Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closes #3077: Address PHP 8.1+ deprecation warnings caused by card links with empty URLs. #3078

Merged
merged 1 commit into from
Jan 12, 2024

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Jan 11, 2024

Description

Addresses deprecation warnings caused by cards that have link title values but empty link URL values observed on a Quickstart 2.8.x site.

Related issues

Closes #3077

How to test

  1. Add a card deck to a page with at least one card containing a populated link title field and an empty link URL field
  2. Save the page
  3. View the page
  4. Ensure no deprecation warnings were logged in the recent log messages

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@joeparsons joeparsons added bug Something isn't working patch release Issues to be included in the next patch release php Pull requests that update Php code labels Jan 11, 2024
@joeparsons joeparsons self-assigned this Jan 11, 2024
@joeparsons joeparsons changed the title Closes #3077: Address deprecation caused by card links empty URLs. Closes #3077: Address deprecation caused by card links with empty URLs. Jan 11, 2024
@joeparsons joeparsons changed the title Closes #3077: Address deprecation caused by card links with empty URLs. Closes #3077: Address deprecation warnings caused by card links with empty URLs. Jan 11, 2024
@joeparsons joeparsons changed the title Closes #3077: Address deprecation warnings caused by card links with empty URLs. Closes #3077: Address PHP 8.1+ deprecation warnings caused by card links with empty URLs. Jan 11, 2024
@joeparsons joeparsons marked this pull request as ready for review January 11, 2024 21:13
@joeparsons joeparsons requested a review from a team as a code owner January 11, 2024 21:13
@trackleft trackleft merged commit 5c38792 into main Jan 12, 2024
13 checks passed
@trackleft trackleft deleted the issue/3077 branch January 12, 2024 17:29
joeparsons added a commit that referenced this pull request Jan 17, 2024
…nks with empty URLs. (#3078)

Closes #3077: Address deprecation caused by card links empty URLs.
joeparsons added a commit that referenced this pull request Jan 19, 2024
…nks with empty URLs. (#3078)

Closes #3077: Address deprecation caused by card links empty URLs.
akslay pushed a commit that referenced this pull request Jan 19, 2024
…nks with empty URLs. (#3078)

Closes #3077: Address deprecation caused by card links empty URLs.
@joeparsons joeparsons mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release php Pull requests that update Php code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cards links with titles and empty URLs trigger PHP 8.1+ deprecation warnings
4 participants