Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#2084 Add media_library_theme_reset to list of deprecated Quickstart modules. #2996

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

joeparsons
Copy link
Member

@joeparsons joeparsons commented Dec 6, 2023

Description

We already added a DB update to uninstall the officially deprecated media_library_theme_reset back in 2.6.x but haven't yet followed up with an update to remove the module from Quickstart.

We should probably add it to our list of Quickstart deprecated modules before actually removing it (?)

Related issues

#2084

How to test

Types of changes

Arizona Quickstart (install profile, custom modules, custom theme)

  • Patch release changes
    • Bug fix
    • Accessibility, performance, or security improvement
    • Critical institutional link or brand change
    • Adding experimental module
    • Update experimental module
  • Minor release changes
    • New feature
    • Breaking or visual change to existing behavior
    • Upgrade experimental module to stable
    • Enable existing module by default or database update
    • Non-critical brand change
    • New internal API or API improvement with backwards compatibility
    • Risky or disruptive cleanup to comply with coding standards
    • High-risk or disruptive change (requires upgrade path, risks regression, etc.)
  • Other or unknown
    • Other or unknown

Drupal core

  • Patch release changes
    • Security update
    • Patch level release (non-security bug-fix release)
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major or minor level update
  • Other or unknown
    • Other or unknown

Drupal contrib projects

  • Patch release changes
    • Security update
    • Patch or minor level update
    • Add new module
    • Patch removal that's no longer necessary
  • Minor release changes
    • Major level update
  • Other or unknown
    • Other or unknown

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

…modules.

We already added a [DB update](#2090) to uninstall this the officially deprecated [media_library_theme_reset](https://drupal.org/proejct/media_library_theme_reset) back in 2.6.x but haven't yet followed up with an update to remove the module from Quickstart.

We should probably add it to our list of Quickstart deprecated modules before actually removing it (?)
@joeparsons joeparsons added the task Work that doesn't always require a pull request. label Dec 6, 2023
@joeparsons joeparsons self-assigned this Dec 6, 2023
@joeparsons joeparsons requested a review from a team as a code owner December 6, 2023 19:59
@joeparsons joeparsons added the patch release Issues to be included in the next patch release label Dec 6, 2023
@trackleft trackleft linked an issue Dec 7, 2023 that may be closed by this pull request
@trackleft trackleft merged commit f78adde into main Dec 7, 2023
13 checks passed
@trackleft trackleft deleted the issue/2084-deprecate branch December 7, 2023 17:22
@joeparsons joeparsons mentioned this pull request Dec 14, 2023
@joeparsons joeparsons mentioned this pull request Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch release Issues to be included in the next patch release task Work that doesn't always require a pull request.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Media Library Theme Reset module is deprecated
3 participants