Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modules using Configuration Overrides should declare dependency on az_core #3874

Closed
tadean opened this issue Nov 12, 2024 · 0 comments · Fixed by #3875
Closed

Modules using Configuration Overrides should declare dependency on az_core #3874

tadean opened this issue Nov 12, 2024 · 0 comments · Fixed by #3875
Assignees
Labels
bug Something isn't working patch release Issues to be included in the next patch release

Comments

@tadean
Copy link
Contributor

tadean commented Nov 12, 2024

Problem/Motivation

On new site install, the az_comprehensive tag is not set as the default container. This is new in 2.11.x. This occurs because it seems in Drupal 10.3 module install order has changed slightly. Since az_google_tag does not declare a dependency on az_core it is not being installed before it anymore. This means the overrides are not automatically applied as expected.

Overrides are still available as a distribution update.

Describe the bug

Override configuration is not installed automatically during site install for some modules that do not declare a dependency on az_core

To Reproduce

  • install a new site on 2.11.x+
  • inspect google tag settings
  • verify that the az_comprehensive tag is not set as default as expected

Proposed resolution

Declare dependencies on az_core for modules where configuration overrides exist.

Expected behavior

Modules with Quickstart overrides should install after az_core because they require the QuickstartConfigProvider

@tadean tadean added bug Something isn't working patch release Issues to be included in the next patch release labels Nov 12, 2024
@tadean tadean self-assigned this Nov 12, 2024
@github-project-automation github-project-automation bot moved this to Todo in 2.12.2 Nov 12, 2024
tadean pushed a commit that referenced this issue Nov 12, 2024
@bberndt-uaz bberndt-uaz removed this from 2.12.2 Nov 13, 2024
@bberndt-uaz bberndt-uaz moved this from To triage to In progress in 2.11.x Patch Release Issues Nov 13, 2024
joeparsons pushed a commit that referenced this issue Nov 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in 2.12.0 Stable Release Issues Nov 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in 2.11.x Patch Release Issues Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working patch release Issues to be included in the next patch release
Projects
Status: Done
Status: Done
1 participant