Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full-width paragraphs may have wrong width when not in the Content region #3817

Closed
bberndt-uaz opened this issue Oct 24, 2024 · 0 comments · Fixed by #3818
Closed

Full-width paragraphs may have wrong width when not in the Content region #3817

bberndt-uaz opened this issue Oct 24, 2024 · 0 comments · Fixed by #3818
Assignees
Labels
backport Changes to be back-ported to previous minor release branch bug Something isn't working high priority Must get done for this milestone patch release Issues to be included in the next patch release

Comments

@bberndt-uaz
Copy link
Contributor

bberndt-uaz commented Oct 24, 2024

Describe the bug

Pull request #3774 updated the styling of full-width paragraphs to apply to all regions, not just the Content region:

However, although this resolved the issue for Text on Media paragraphs in certain regions (like Content Top), it introduced an additional bug where full-width Text with Background or Text on Media paragraphs can have the incorrect width in regions other than Content:

image

This problem occurs due to this CSS rule being incorrectly applied to full-width paragraphs which are not in the Content region:

.region .full-width-background {
    margin-left: var(--full-width-left-distance);
    margin-right: var(--full-width-right-distance);
    overflow: hidden;
}

The CSS variables above are calculated specifically for the Content region and should not be used in relation to other regions.

To Reproduce

Steps to reproduce the behavior:

  1. Create a flexible block with a full-width Text with Background paragraph.
  2. In Block Layout, add the block to a region such as Full width content bottom or Content bottom.
  3. Observe that the Text with Background paragraph is not full-width: there is a large margin on the right side.

Proposed resolution

Revert one or more of the changes from #3774 and update CSS as needed to fix remaining issues specific to Text with Background paragraphs.

Expected behavior

Paragraphs with the "Full width" checkbox checked should use the full width of the page.

@bberndt-uaz bberndt-uaz added bug Something isn't working high priority Must get done for this milestone labels Oct 24, 2024
@bberndt-uaz bberndt-uaz self-assigned this Oct 24, 2024
@bberndt-uaz bberndt-uaz added backport Changes to be back-ported to previous minor release branch patch release Issues to be included in the next patch release labels Oct 24, 2024
bberndt-uaz added a commit that referenced this issue Nov 1, 2024
bberndt-uaz added a commit that referenced this issue Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport Changes to be back-ported to previous minor release branch bug Something isn't working high priority Must get done for this milestone patch release Issues to be included in the next patch release
Projects
None yet
1 participant