Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drupal 10.3.x updated coding standards getting applied to Quickstart 2.10.x (Drupal 10.2.x) checks #3581

Closed
joeparsons opened this issue Jul 30, 2024 · 2 comments · Fixed by #3583
Closed

Drupal 10.3.x updated coding standards getting applied to Quickstart 2.10.x (Drupal 10.2.x) checks #3581

joeparsons opened this issue Jul 30, 2024 · 2 comments · Fixed by #3583
Assignees
@joeparsons
Labels
2.9.x only 2.10.x only bug Something isn't working ci Continuous integration / automation

Comments

@joeparsons
Copy link
Member

Problem/Motivation

The drupal/core-dev: * requirement in our az-digital/az-quickstart-dev metapackage is allowing the Drupal 10.3.x version of the drupal/core-dev package to be installed on Quickstart 2.10.x and 2.9.x.

Describe the bug

See https://github.com/az-digital/az_quickstart/actions/runs/10170520570/job/28129801931

During a composer install from the HEAD of the 2.10.x branch:

 - Installing drupal/core-dev (10.3.1)

Result of phpcs:

phpcs -p --colors --standard=web/profiles/custom/az_quickstart/phpcs.xml.dist
.EEE...EEE 10 / 10 (100%)



FILE: ..._event/az_event_trellis/src/Plugin/migrate/source/AZTrellisEventSource.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...art/modules/custom/az_http/src/Plugin/migrate_plus/data_fetcher/AzHttp.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...rc/Plugin/better_exposed_filters/filter/AZFinderTaxonomyIndexTidWidget.php
--------------------------------------------------------------------------------
FOUND 3 ERRORS AFFECTING 3 LINES
--------------------------------------------------------------------------------
  3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
 83 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 99 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 3 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...art/modules/custom/az_news/az_news_feeds/src/Form/AzNewsFeedsAdminForm.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 39 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 40 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 2 spaces but found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...az_news/az_news_feeds/src/EventSubscriber/AzNewsFeedsMigrateSubscriber.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
 [28](https://github.com/az-digital/az_quickstart/actions/runs/10170520570/job/28129801931#step:7:29) | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 [29](https://github.com/az-digital/az_quickstart/actions/runs/10170520570/job/28129801931#step:7:30) | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 2 spaces but found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ustom/az_finder/src/Plugin/views/exposed_form/QuickstartExposedFilters.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ..._paragraphs/src/Plugin/Field/FieldFormatter/AZBackgroundMediaFormatter.php
--------------------------------------------------------------------------------
FOUND 6 ERRORS AFFECTING 5 LINES
--------------------------------------------------------------------------------
 66 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 6
 67 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 6
 68 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 6
 69 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 4 spaces but found 6
 69 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
 70 | ERROR | [x] Multi-line function declaration not indented correctly;
    |       |     expected 2 spaces but found 4
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 6 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ofiles/custom/az_quickstart/modules/custom/az_finder/src/AZFinderIcons.php
--------------------------------------------------------------------------------
FOUND 1 ERROR AFFECTING 1 LINE
--------------------------------------------------------------------------------
 3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 1 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------


FILE: ...ckstart/modules/custom/az_core/src/Drush/Commands/AZEntityListCommands.php
--------------------------------------------------------------------------------
FOUND 2 ERRORS AFFECTING 2 LINES
--------------------------------------------------------------------------------
  3 | ERROR | [x] Expected strict_types=1, found strict_types = 1.
 29 | ERROR | [x] Multi-line function declarations must have a trailing comma
    |       |     after the last parameter
--------------------------------------------------------------------------------
PHPCBF CAN FIX THE 2 MARKED SNIFF VIOLATIONS AUTOMATICALLY
--------------------------------------------------------------------------------

Time: 7.98 secs; Memory: [30](https://github.com/az-digital/az_quickstart/actions/runs/10170520570/job/28129801931#step:7:31)MB

To Reproduce

composer install from the HEAD of the 2.10.x or 2.9.x branch.

Proposed resolution

Add a drupal/core-dev require-dev constraint to az-digital/az_quickstart's composer.json in the 2.10.x and 2.9.x branches.
@joeparsons joeparsons added bug Something isn't working ci Continuous integration / automation 2.9.x only 2.10.x only labels Jul 30, 2024
@joeparsons joeparsons self-assigned this Jul 30, 2024
joeparsons added a commit that referenced this issue Jul 30, 2024
@joeparsons
Closes #3581: Require correct drupal/core-dev version for 2.10.x.
72cab26
@joeparsons joeparsons mentioned this issue Jul 30, 2024
Closed
32 tasks
@joeparsons joeparsons added this to the 2.10.x Patch Release Issues milestone Jul 30, 2024
@joeparsons joeparsons linked a pull request Jul 30, 2024 that will close this issue
Closes #3581: Require correct drupal/core-dev version for 2.10.x. #3582
Closed
32 tasks
joeparsons added a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.10…
d58532d 
….x branch.
@joeparsons joeparsons mentioned this issue Jul 30, 2024
Merged
joeparsons added a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.10…
5bbcde5 
….x branch.
@joeparsons joeparsons mentioned this issue Jul 30, 2024
Merged
trackleft added a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons @trackleft
az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.10…
5235963 
….x branch. (#160)

Co-authored-by: Chris Green <[email protected]>
trackleft pushed a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.9.…
7f0891f 
…x branch. (#161)

az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.10.x branch.
joeparsons added a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in main…
d357f02 
… branch.
@joeparsons joeparsons mentioned this issue Jul 30, 2024
Merged
joeparsons added a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.11…
ad813a5 
….x branch.
@joeparsons joeparsons mentioned this issue Jul 30, 2024
Merged
joeparsons added a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-composer-scaffold cons…
07e272a 
…traint in 2.10.x branch.
trackleft pushed a commit to az-digital/az-quickstart-scaffolding that referenced this issue Jul 30, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-composer-scaffold cons…
4856bc9 
…traint in 2.10.x branch. (#164)
@joeparsons
Copy link
Member Author

joeparsons commented Jul 30, 2024 •
edited
Loading

Still an issue after the scaffolding repo updates. Seems this may be been caused by us switching from drupal/core-dev-pinned to drupal/core-dev.

@joeparsons joeparsons reopened this Jul 30, 2024
joeparsons added a commit that referenced this issue Jul 31, 2024
@joeparsons
Closes #3581: Apply updated coding standards to 2.10.x branch.
6e066f3
@joeparsons joeparsons mentioned this issue Jul 31, 2024
Merged
32 tasks
@joeparsons joeparsons linked a pull request Jul 31, 2024 that will close this issue
Closes #3581: Apply updated coding standards to 2.10.x branch. #3583
Merged
32 tasks
joeparsons added a commit that referenced this issue Jul 31, 2024
@joeparsons
#3581: Apply updated coding standards to 2.9.x branch.
5795216
@joeparsons joeparsons mentioned this issue Jul 31, 2024
Merged
32 tasks
trackleft pushed a commit that referenced this issue Jul 31, 2024
@joeparsons
Closes #3581: Apply updated coding standards to 2.10.x branch. (#3583)
77636aa
trackleft pushed a commit that referenced this issue Jul 31, 2024
@joeparsons
#3581: Apply updated coding standards to 2.9.x branch. (#3584)
3b68510
@joeparsons
Copy link
Member Author

Completed.

trackleft pushed a commit to az-digital/az-quickstart-scaffolding that referenced this issue Aug 6, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-scaffold and drupal/co…
48d82a0 
…re-dev constraints in 2.11.x branch. (#163)

* az-digital/az_quickstart#3581: Fix drupal/core-dev constraint in 2.11.x branch.

* Update composer.json
trackleft pushed a commit to az-digital/az-quickstart-scaffolding that referenced this issue Aug 6, 2024
@joeparsons
az-digital/az_quickstart#3581: Fix drupal/core-scaffold and drupal/co…
ebe962a 
…re-dev constraints in main branch. (#162)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@joeparsons joeparsons

Labels
2.9.x only 2.10.x only bug Something isn't working ci Continuous integration / automation
Projects
None yet
Milestone
No milestone
2 participants
@joeparsons @trackleft