Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ui)!: improve user experience wrt transparent bg #865

Merged
merged 2 commits into from
Jul 17, 2023
Merged

feat(ui)!: improve user experience wrt transparent bg #865

merged 2 commits into from
Jul 17, 2023

Conversation

Jint-lzxy
Copy link
Collaborator

As per #864. Using the alternative method.

@Jint-lzxy
feat(ui)!: improve user experience wrt transparent bg
e190194 
As per #864. Using the alternative method.
@Jint-lzxy Jint-lzxy requested review from CharlesChiuGit and ayamir and removed request for CharlesChiuGit July 15, 2023 07:41
@Jint-lzxy Jint-lzxy marked this pull request as draft July 15, 2023 07:41
@Jint-lzxy Jint-lzxy added the ui General user interface related issues label Jul 15, 2023
@Jint-lzxy Jint-lzxy linked an issue Jul 15, 2023 that may be closed by this pull request
Improve user experience wrt transparent backgrounds #864
Closed
@ayamir
Copy link
Owner

ayamir commented Jul 15, 2023

image

Seems nvim-treesitter-context doesn't support this.

@Jint-lzxy
Copy link
Collaborator Author

Fixed at 6958716.

ayamir
ayamir approved these changes Jul 16, 2023
View reviewed changes
Copy link
Owner

@ayamir ayamir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM now 👍

@Jint-lzxy Jint-lzxy marked this pull request as ready for review July 16, 2023 10:33
CharlesChiuGit
CharlesChiuGit approved these changes Jul 17, 2023
View reviewed changes
Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@CharlesChiuGit CharlesChiuGit merged commit bfa6e43 into main Jul 17, 2023
@CharlesChiuGit CharlesChiuGit deleted the feat/transparent-bg-improvements branch July 17, 2023 05:15
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request Jul 17, 2023
@Jint-lzxy @singlemancombat
feat(ui)!: improve user experience wrt transparent bg (ayamir#865)
c171a2e
@TonyWu20 TonyWu20 mentioned this pull request Jul 17, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CharlesChiuGit CharlesChiuGit CharlesChiuGit approved these changes

@ayamir ayamir ayamir approved these changes

Assignees
No one assigned
Labels
ui General user interface related issues
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Improve user experience wrt transparent backgrounds
3 participants
@Jint-lzxy @ayamir @CharlesChiuGit