Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui)!: unify UI components: cmp, wilder, floats #772

Merged
merged 3 commits into from
May 30, 2023

Conversation

Jint-lzxy
Copy link
Collaborator

#718 (comment). Further changes:

  • Used branch: refactor/syntax-highlighting that has not yet been merged:
ui["Jint-lzxy/nvim"] = {
	lazy = false,
	branch = "refactor/syntax-highlighting",
	name = "catppuccin",
	config = require("ui.catppuccin"),
}
  • Simplified cmp.formatting.format()
  • Pinned cmp-treesitter at commit c8e3a74 b/c we probably don't need that new feature, and it's also a source of trouble.

---------
Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>
@Jint-lzxy
Copy link
Collaborator Author

cc @huge-pancake

@ayamir
Copy link
Owner

ayamir commented May 29, 2023

LGTM for current UI, but seems lack the change of lspsaga outline and lualine.
Oh I see, it's just part one lol.
But after the entry name like [LSP] set, other completion candidates provided by vanilla nvim which have no such entry name look like something is missing. Maybe we should disable it at later commits.

@vollowx
Copy link

vollowx commented May 29, 2023

Current at school so that can't review now. Will have a look on this weekend.

@Jint-lzxy
Copy link
Collaborator Author

But after the entry name like [LSP] set, other completion candidates provided by vanilla nvim which have no such entry name look like something is missing. Maybe we should disable it at later commits.

The __index metamethod would do the trick :)

@CharlesChiuGit
Copy link
Collaborator

CharlesChiuGit commented May 30, 2023

LGTM for current UI, but seems lack the change of lspsaga outline and lualine. Oh I see, it's just part one lol. But after the entry name like [LSP] set, other completion candidates provided by vanilla nvim which have no such entry name look like something is missing. Maybe we should disable it at later commits.

Addition on ayamir mentioned, is some candidates got cross out intended?
圖片

Copy link
Collaborator

@CharlesChiuGit CharlesChiuGit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! this is super nice!

@ayamir
Copy link
Owner

ayamir commented May 30, 2023

I disabled nvim built-in completion by set complete = "" and completeopt = "" in options.lua but didn't work. So the candidates without menu may be produced by other sources.

@Jint-lzxy
Copy link
Collaborator Author

c81165b

Addition on ayamir mentioned, is some candidates got cross out intended?

Ys they are defined by the language server (usually denoting this entry is deprecated).

@Jint-lzxy
Copy link
Collaborator Author

I disabled nvim built-in completion by set complete = "" and completeopt = "" in options.lua but didn't work. So the candidates without menu may be produced by other sources.

Can't wrap my head around this 😢 I've never encountered this issue before (copilot disabled)

Is it related to completefunc? :h complete-functions

@ayamir
Copy link
Owner

ayamir commented May 30, 2023

I disabled nvim built-in completion by set complete = "" and completeopt = "" in options.lua but didn't work. So the candidates without menu may be produced by other sources.

Can't wrap my head around this 😢 I've never encountered this issue before (copilot disabled)

Is it related to completefunc? :h complete-functions

It's ok now, the unknown source is treesitter. Can merge it.

@Jint-lzxy Jint-lzxy merged commit fcc8623 into main May 30, 2023
@Jint-lzxy Jint-lzxy deleted the refactor/ui-part-1 branch May 30, 2023 14:37
singlemancombat pushed a commit to singlemancombat/nvim-config that referenced this pull request May 30, 2023
* feat(ui)!: unify UI components: cmp, wilder, floats

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>

* fix entry tags

* fixup! fix entry tags

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>
leavers pushed a commit to leavers/nvimdots that referenced this pull request May 31, 2023
* feat(ui)!: unify UI components: cmp, wilder, floats

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>

* fix entry tags

* fixup! fix entry tags

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>
csyJoy pushed a commit to csyJoy/nvimdots that referenced this pull request Jun 4, 2023
* feat(ui)!: unify UI components: cmp, wilder, floats

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>

* fix entry tags

* fixup! fix entry tags

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>
@vollowx vollowx mentioned this pull request Jun 10, 2023
bleedingfight pushed a commit to bleedingfight/nvimdots that referenced this pull request Jun 22, 2023
* feat(ui)!: unify UI components: cmp, wilder, floats

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>

* fix entry tags

* fixup! fix entry tags

---------

Signed-off-by: Jint-lzxy <[email protected]>
Co-authored-by: huge-pancake <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants