Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update wording on LLVM versions #139

Merged
merged 2 commits into from
Oct 31, 2023
Merged

Update wording on LLVM versions #139

merged 2 commits into from
Oct 31, 2023

Conversation

dmitris
Copy link
Contributor

@dmitris dmitris commented Sep 27, 2023

No description provided.

@netlify
Copy link

netlify bot commented Sep 27, 2023

Deploy Preview for aya-rs ready!

Name Link
🔨 Latest commit 286d5b3
🔍 Latest deploy log https://app.netlify.com/sites/aya-rs/deploys/6540d4ef6689fd0008f50eb6
😎 Deploy Preview https://deploy-preview-139--aya-rs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@@ -20,7 +20,7 @@ cargo install bpf-linker
```

If you are running **macos, or linux on any other architecture**, you need to
install LLVM 16 first (for example, with `brew install llvm`),
install the current LLVM first (for example, with `brew install llvm`),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just "LLVM"?

Copy link
Contributor Author

@dmitris dmitris Sep 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How about just "LLVM"?

I think then it wouldn't be clear that not any version of LLVM will work but one needs the specific / current one.

Maybe we should say install or update LLVM?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In that case we should say 17.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or just "the newest stable version". Like, literally, whatever is the latest stable on apt.llvm.org at the moment. And users of non-Debian/Ubuntu distros will understand and figure out what to do. :)

Rust nightly is always switching to new LLVM already when the first rc-s are available. And we are planning to do binstalls anyway. So I don't think that manually editing the doc just to bump the version number is worth an effort.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changed to the newest stable version and in crosscompile.md added a mention of and link to the llvm-sys crate and its major version

@vadorovsky vadorovsky changed the title update for LLVM17 Update wording on LLVM versions Oct 31, 2023
@vadorovsky vadorovsky merged commit bfe031e into aya-rs:main Oct 31, 2023
@dmitris dmitris deleted the llvm17 branch November 1, 2023 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants