Merge pull request #72 from minnerbe/fix/hang-empty-collection

Fix potential hang when exceptions are thrown during concurrent optimization
axtimwalde · Oct 29, 2024 · ba36e15 · ba36e15
2 parents 35ea550 + 0819849
commit ba36e15
Showing 1 changed file with 7 additions and 3 deletions.
diff --git a/mpicbg/src/main/java/mpicbg/models/TileUtil.java b/mpicbg/src/main/java/mpicbg/models/TileUtil.java
@@ -249,9 +249,13 @@ private static Void fitAndApplyWorker(
 			final boolean canBeProcessed = Collections.disjoint(tile.getConnectedTiles(), executingTiles);
 
 			if (canBeProcessed) {
-				tile.fitModel();
-				tile.apply(damp);
-				executingTiles.remove(tile);
+				try {
+					tile.fitModel();
+					tile.apply(damp);
+				} finally {
+					// clean up if there was an exception, otherwise this can cause a deadlock
+					executingTiles.remove(tile);
+				}
 			} else {
 				executingTiles.remove(tile);
 				pendingTiles.addLast(tile);