style(engine): expose atom for panic_error term

[ccamel]

Self explanatory.

[coderabbitai]

Walkthrough

The changes introduce a new global variable AtomPanicError in engine/promise.go, which is initialized to streamline panic error handling. The panicError function now utilizes this variable to create Exception instances instead of generating a new atom for each panic error. Additionally, the PanicError struct and its associated error method have been removed, indicating a shift in how panic-related errors are managed within the promise execution context. This results in a more efficient and consistent error handling mechanism.

Changes

File	Change Summary
engine/promise.go	- Added global variable AtomPanicError. - Updated panicError function to use AtomPanicError. - Removed PanicError struct and its Error method.

Possibly related PRs

• Wrap panic errors  #7: The changes in this PR involve modifications to the panicError function in engine/promise.go, which directly relates to the main PR's updates to the same function, including the introduction of a new error handling structure.

Suggested reviewers

• bdeneux
• amimart

---

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

@@            Coverage Diff             @@
##             main      #23      +/-   ##
==========================================
+ Coverage   97.87%   97.89%   +0.02%     
==========================================
  Files          24       24              
  Lines        7844     7842       -2     
==========================================
  Hits         7677     7677              
+ Misses        134      132       -2     
  Partials       33       33              

Files with missing lines	Coverage Δ
engine/promise.go	100.00% <100.00%> (+1.63%)	⬆️

[coderabbitai]

Actionable comments posted: 0

🧹 Outside diff range and nitpick comments (2)

engine/promise.go (2)

13-15: LGTM! Consider adding documentation for the exported variable.

The new exported variable follows Go conventions and aligns with the PR objective to expose the panic_error atom.

Consider adding a godoc comment to document this exported variable's purpose and usage, for example:

+// AtomPanicError represents the atom used for panic error terms in the Prolog engine
 var (
     AtomPanicError = NewAtom("panic_error")
 )

---

172-172: Consider caching frequently occurring error messages as atoms.

The implementation creates new atoms for each unique error message. While this is generally fine, consider caching commonly occurring error messages as predefined atoms if performance profiling shows high atom creation overhead in error paths.

Also applies to: 174-174

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL

📥 Commits

Reviewing files that changed from the base of the PR and between b16f8f9 and 84f0213.

📒 Files selected for processing (1)

• engine/promise.go (2 hunks)

🔇 Additional comments (1)

engine/promise.go (1)

172-174: Verify complete removal of PanicError references.

The changes remove the PanicError struct in favor of using Exception directly. Let's verify there are no remaining references to the removed type.