-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build/go fast #616
Build/go fast #616
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
WalkthroughThe changes involve the removal of the Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
Documentation and Community
|
Dependencies added@docusaurus/faster
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Outside diff range and nitpick comments (2)
package.json (2)
32-32
: LGTM! Good architectural improvement for build performance.The addition of
@docusaurus/faster
aligns with Docusaurus 3.6's adoption strategy for improved build performance. This change, combined with the removal ofbabel.config.js
, indicates a shift towards modern build tooling that should result in faster builds.
Line range hint
71-72
: Align Docusaurus dev dependency versionsThe Docusaurus type-related dev dependencies are on different versions:
- @docusaurus/module-type-aliases: ^3.6.1
- @docusaurus/types: ^3.5.2
While this might work, it's recommended to align all Docusaurus packages to the same major.minor version (3.6.3) to ensure type consistency.
"devDependencies": { - "@docusaurus/module-type-aliases": "^3.6.1", - "@docusaurus/types": "^3.5.2", + "@docusaurus/module-type-aliases": "^3.6.3", + "@docusaurus/types": "^3.6.3",
📜 Review details
Configuration used: .coderabbit.yaml
Review profile: CHILL
⛔ Files ignored due to path filters (1)
yarn.lock
is excluded by!**/yarn.lock
,!**/*.lock
📒 Files selected for processing (3)
babel.config.js
(0 hunks)docusaurus.config.js
(1 hunks)package.json
(1 hunks)
💤 Files with no reviewable changes (1)
- babel.config.js
✅ Files skipped from review due to trivial changes (1)
- docusaurus.config.js
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device | URL |
---|---|
desktop | http://localhost:3000/ |
Device | URL |
---|---|
mobile | http://localhost:3000/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
LGTM |
Time to go faster - https://docusaurus.io/blog/releases/3.6#adoption-strategy
Summary by CodeRabbit
New Features
Chores