-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: force light mode #452
Conversation
WalkthroughA recent update was made to the project's configuration, specifically within the Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (1)
- docusaurus.config.js (1 hunks)
Additional comments: 1
docusaurus.config.js (1)
- 323-324: The changes made to the
colorMode
configuration, specifically settingrespectPrefersColorScheme
tofalse
, effectively enforce the light mode across the application, disregarding user's system-wide color scheme preferences. This aligns with the PR's objectives and ensures a consistent visual experience for all users. However, it's important to communicate this change clearly to users, especially those who might prefer dark mode due to accessibility reasons or personal preference.Consider adding a note or documentation on how users can manually switch to dark mode if needed, assuming future updates might include a toggle option for user preference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device | URL |
---|---|
desktop | http://localhost:3000/ |
Device | URL |
---|---|
mobile | http://localhost:3000/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems good! Thanks 👍
This PR aims to force the light mode even if the preferred mode of the navigator or the cookies are set up on dark mode.
Summary by CodeRabbit