Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: force light mode #452

Merged
merged 1 commit into from
Mar 11, 2024
Merged

fix: force light mode #452

merged 1 commit into from
Mar 11, 2024

Conversation

MdechampG
Copy link
Member

@MdechampG MdechampG commented Mar 11, 2024

This PR aims to force the light mode even if the preferred mode of the navigator or the cookies are set up on dark mode.

Summary by CodeRabbit

  • Refactor
    • Updated the website's color mode settings to not automatically match the user's system theme preference.

Copy link
Contributor

coderabbitai bot commented Mar 11, 2024

Walkthrough

A recent update was made to the project's configuration, specifically within the docusaurus.config.js file. This update involves the color scheme preference settings, where the respectPrefersColorScheme option has been explicitly set to false. This change affects how the website's color theme is determined, disregarding the user's system-wide color scheme preferences.

Changes

File Change Summary
docusaurus.config.js Added respectPrefersColorScheme: false to colorMode configuration

🐇✨
In the land of code and hue,
A rabbit hopped, and changes it drew.
"No more dark or light on cue,
My colors stay, as I wish them to!"
With a click and a hop, the deed was done,
In docusaurus.config, the battle won.
🌈🐰

Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share

Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit-tests for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit tests for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit tests.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • The JSON schema for the configuration file is available here.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/coderabbit-overrides.v2.json

CodeRabbit Discord Community

Join our Discord Community to get help, request features, and share feedback.

@MdechampG MdechampG requested a review from ccamel March 11, 2024 08:01
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review Status

Actionable comments generated: 0

Configuration used: CodeRabbit UI

Commits Files that changed from the base of the PR and between 15b149d and c37fe32.
Files selected for processing (1)
  • docusaurus.config.js (1 hunks)
Additional comments: 1
docusaurus.config.js (1)
  • 323-324: The changes made to the colorMode configuration, specifically setting respectPrefersColorScheme to false, effectively enforce the light mode across the application, disregarding user's system-wide color scheme preferences. This aligns with the PR's objectives and ensures a consistent visual experience for all users. However, it's important to communicate this change clearly to users, especially those who might prefer dark mode due to accessibility reasons or personal preference.

Consider adding a note or documentation on how users can manually switch to dark mode if needed, assuming future updates might include a toggle option for user preference.

Copy link
Member

@bot-anik bot-anik left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Device URL
desktop http://localhost:3000/

Device URL
mobile http://localhost:3000/

Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead

Copy link
Member

@ccamel ccamel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good! Thanks 👍

@MdechampG MdechampG merged commit 5552d4f into main Mar 11, 2024
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants