-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflow): improve commit message for updated documentation #445
Conversation
WalkthroughThis update enhances the process of updating versioned documentation by refining the commit messages and branch naming conventions. It aims to make the documentation updates more organized and traceable by including repository-specific information in commit messages and adopting a more structured approach to branch names. Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 2
Configuration used: CodeRabbit UI
Files selected for processing (1)
- .github/workflows/update-versioned-docs.yml (1 hunks)
Additional comments: 3
.github/workflows/update-versioned-docs.yml (3)
- 89-89: The updated commit message format now includes the repository name, which enhances clarity and context. This is a positive change as it makes the commit history more informative, especially when managing documentation across multiple repositories.
- 95-95: Similarly, the commit message for creating a pull request has been updated to include the repository name. This change aligns with the objective of making commit messages more descriptive and useful for tracking documentation updates.
- 98-98: The change in branch naming convention from
docs/
tofeat/
suggests a reclassification of documentation updates as features. While this could align with the project's versioning strategy, it's important to ensure that this change is communicated and agreed upon by the team to maintain workflow consistency.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice catch !
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device | URL |
---|---|
desktop | http://localhost:3000/ |
Device | URL |
---|---|
mobile | http://localhost:3000/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
Self explanatory.
Summary by CodeRabbit