-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci(workflow): add lint-web job #347
Conversation
WalkthroughThe changes introduced across the workflows primarily focus on enhancing the caching mechanism by incorporating yarn cache configurations. A new job, "lint-web", has been added to the lint workflow, which includes setting up a Node environment, running Lighthouse for performance testing, and uploading the reports. Changes
Poem
TipsChat with CodeRabbit Bot (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Device | URL |
---|---|
desktop | http://localhost:3000/ |
Device | URL |
---|---|
mobile | http://localhost:3000/ |
Not what you expected? Are your scores flaky? GitHub runners could be the cause.
Try running on Foo instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/workflows/lint.yml (2 hunks)
- .github/workflows/publish.yml (1 hunks)
- .github/workflows/update-versioned-docs.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/publish.yml
Additional comments: 4
.github/workflows/update-versioned-docs.yml (1)
- 63-66: The addition of caching for yarn dependencies in the setup-node action is a good practice for improving the efficiency of the workflow. However, ensure that the cache key is properly invalidated when dependencies change. This is usually handled by the setup-node action itself, but it's worth verifying.
.github/workflows/lint.yml (3)
94-147: The new "lint-web" job looks well-structured and follows the standard pattern for setting up a Node environment, fetching dependencies, starting a web server, running Lighthouse for performance testing, uploading the reports, and stopping the web server. Ensure that the
WEB_PORT
environment variable does not conflict with any other services running on the same port.148-150: The "report-new-dependencies" job now includes a cache setting for yarn. This should improve the efficiency of dependency management. However, ensure that the cache is invalidated and updated correctly when dependencies change.
202-208: The cache configuration for yarn has been added to the "lint-scss" job in the setup-node action. This should improve the efficiency of dependency management. However, ensure that the cache is invalidated and updated correctly when dependencies change.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 0
Configuration used: CodeRabbit UI
Files selected for processing (3)
- .github/workflows/lint.yml (2 hunks)
- .github/workflows/publish.yml (1 hunks)
- .github/workflows/update-versioned-docs.yml (1 hunks)
Files skipped from review due to trivial changes (1)
- .github/workflows/publish.yml
Additional comments: 4
.github/workflows/update-versioned-docs.yml (1)
- 63-66: The addition of caching for yarn in the setup-node action is a good practice for improving build times. However, ensure that the cache key is properly invalidated when dependencies change. This is typically done by including a hash of
yarn.lock
in the cache key..github/workflows/lint.yml (3)
97-146: The new "lint-web" job looks well-structured and follows the best practices for GitHub Actions. It sets up a Node environment, fetches dependencies, starts a web server, runs Lighthouse for performance testing, uploads the reports, and then stops the web server. Ensure that the
OKP4_TOKEN
secret is set in the repository settings.148-149: The "report-new-dependencies" job now includes a cache setting for yarn. This should improve the performance of the job by caching dependencies between runs. However, ensure that the caching behavior does not introduce any unexpected side effects, especially when dependencies are updated.
201-204: The setup-node action in the "lint-scss" job now includes a cache setting for yarn. This should improve the performance of the job by caching dependencies between runs. However, ensure that the caching behavior does not introduce any unexpected side effects, especially when dependencies are updated.
Self explanatory (similar to okp4/dataverse-portal).
Summary by CodeRabbit